Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox for android wrong browser name #138

Closed
tapalilov opened this issue Feb 18, 2015 · 3 comments
Closed

Firefox for android wrong browser name #138

tapalilov opened this issue Feb 18, 2015 · 3 comments

Comments

@tapalilov
Copy link

When browser is firefox for android, browser.name method return 'android' as name.

from s5:

RuntimeError (#<Browser:0x000000068913d0 @user_agent="Mozilla/5.0 (Android; Mobile; rv:35.0) Gecko/35.0 Firefox/35.0", @accept_language="en-us,bg-bg;q=0.7,en;q=0.3">):

from lenovo tablet:

RuntimeError (#<Browser:0x007f5b65740e88 @user_agent="Mozilla/5.0 (Android; Tablet; rv:34.0) Gecko/34.0 Firefox/34.0", @accept_language="en-US,en;q=0.5">):
@miketaylr
Copy link

It also fails to detect Firefox OS tablets and browsers.

@fnando, I'm happy to send a PR with tests if you're interested. Thoughts?

@fnando fnando closed this as completed in ce5c4a1 Jun 3, 2015
@fnando
Copy link
Owner

fnando commented Jun 3, 2015

Sorry, people. Didn't read these comments, so I implemented it myself.

@miketaylr
Copy link

cool. 👍

ellimist pushed a commit to ellimist/browser that referenced this issue Mar 15, 2017
@fnando @ellimist
Set correct name for Firefox running on Android. Close fnando#138.
ec06313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fnando @miketaylr @tapalilov