set UTF-8 encoding to translations.js.erb #139
Conversation
|
👍 |
|
👍 |
|
Merge pls pls |
|
+1 for this, somewhat urgent as it's tied to a Rails security update. |
|
you can use to following line in your gemfile until the PR is merged
|
|
Yup, that's what I'm using now. |
|
Please merge and release it. |
|
and |
|
@tkawachi, bundler has a special github syntax with default master branch: |
|
Please merge and release it. |
|
👍 |
|
@aratak Thanks I did't know. |
|
This fix didn't actually work for me. When the encoding is specified it seems to stop the required files specified in the manifest from being included too. This leads to I moved the translations into their own file (#140) so that only the translations and encoding were specified and there was no encoding specified in the manifest file and all seems to work fine. |
|
Author just add this commit |
|
Thanx @aratak , I switched to the github master like you said and it works fine |
|
@rocknruby Have you tried branch |
|
No, just: gem 'i18n-js', :github => 'fnando/i18n-js' |
|
+1 for merge. This fixed upgrading to Rails 3.2.13 for us as well. I am stuck using: Gemfile: # Using the master branch until there is a fix for https://github.com/fnando/i18n-js/issues/137
gem 'i18n-js', :github => 'fnando/i18n-js'
# gem 'i18n-js', '= 2.1.2'Since we use vendor/cache for caching our gems for deployment, I had to run: |
|
This is really annoying. I can't use the github syntax since I use i18n-js in a gem, so I can only specify versions, not repositories. The only solution for now is to add this github line to all gemfiles including my gem, which is not nice. Please merge and update the gemserver... |
|
I have no idea why this is not merged...plus some other PR |
|
any chance this gets merged some day? |
|
There are a few PR should merged as soon as possible |
|
@fnando y u no merge? |
|
this fix works for me too.. |
|
👍 |
|
The last commit on this repo is a year old. I mailed the owner, no response. Is there anyone who wants to fork this and maintain the gem? I like this gem, we use it on different production systems, but maybe it's time to admit this is old unmaintained code? |
|
@cimm The last commit is not a year ago |
|
@PikachuEXE Oh, sorry, didn't notice that. Thanks for pointing out. |
|
I too emailed the owner a couple weeks ago (had Google translate it to Portuguese...). No luck, either. |
|
Sorry people! I'll work on these PRs this weekend. Too busy. :( Abraços! Nando Vieira On 20/06/2013, at 12:30, Adam Grant notifications@github.com wrote:
|
|
@fnando I would be happy to help with bugs if needed, even if it's just verifying or writing failing test cases. |
|
@fnando Can you please merge this? |
|
I just started using this gem and ran into this issue on @fnando when do you plan to do a new release? |
|
@fnando Merge please |
|
@fnando I see that this fix is already on master, but it isn't out on rubygems with a new version number. When you get a chance, would you mind pushing the newest up to rubygems? Thanks! |
|
Temporary gem: http://rubygems.org/gems/i18n-js-pika |
|
Is this now fixed on master? If so, may we close this PR? |
This fixes issue #137.
The file translations.js.erb should be forced to use UTF-8 or there will be an 'invalid byte sequence'-error in Rails 3.2.13 when non us-ascii characters are used in some translation files.