-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builtin support for SQLite schema table #1166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnc12
approved these changes
Mar 26, 2023
I packed a bunch of other code quality improvements into this PR because they popped up while I was working on it. Most notable:
|
fnc12
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to add the table "sqlite_master" to a storage and select from it or its alias "sqlite_schema".
Additionally:
Still open for discussion:
This fact can be deduced from the following:
If the set of columns is qualified, the following select statement will fail with the error "no such table: sqlite_schema":
SELECT sqlite_schema.* from sqlite_schema
.So I suggest keeping the previous table name "sqlite_master" and providing "sqlite_schema" as a table alias in sqlite_orm.
get_all<Object>()
intended to be shorthand forselect(object<Object>())
? If so, it makes sense to provide overloads for selecting from an alias table. Otherwise I don't want to fall into over-engineering.