chore: remove unused util function

fnlctrl · Oct 24, 2019 · 516501e · 516501e
1 parent f7a7e8d
commit 516501e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 49 deletions.
diff --git a/packages/compiler-core/__tests__/utils.spec.ts b/packages/compiler-core/__tests__/utils.spec.ts
@@ -1,9 +1,5 @@
-import { Position, NodeTypes } from '../src/ast'
-import {
-  getInnerRange,
-  advancePositionWithClone,
-  isEmptyExpression
-} from '../src/utils'
+import { Position } from '../src/ast'
+import { getInnerRange, advancePositionWithClone } from '../src/utils'
 
 function p(line: number, column: number, offset: number): Position {
   return { column, line, offset }
@@ -71,41 +67,3 @@ describe('getInnerRange', () => {
     expect(loc2.end.offset).toBe(7)
   })
 })
-
-describe('isEmptyExpression', () => {
-  test('empty', () => {
-    expect(
-      isEmptyExpression({
-        content: '',
-        type: NodeTypes.SIMPLE_EXPRESSION,
-        isStatic: true,
-        isConstant: true,
-        loc: null as any
-      })
-    ).toBe(true)
-  })
-
-  test('spaces', () => {
-    expect(
-      isEmptyExpression({
-        content: '  \t  ',
-        type: NodeTypes.SIMPLE_EXPRESSION,
-        isStatic: true,
-        isConstant: true,
-        loc: null as any
-      })
-    ).toBe(true)
-  })
-
-  test('identifier', () => {
-    expect(
-      isEmptyExpression({
-        content: 'foo',
-        type: NodeTypes.SIMPLE_EXPRESSION,
-        isStatic: true,
-        isConstant: true,
-        loc: null as any
-      })
-    ).toBe(false)
-  })
-})
diff --git a/packages/compiler-core/src/utils.ts b/packages/compiler-core/src/utils.ts
@@ -164,7 +164,7 @@ export function findProp(
     const p = node.props[i]
     if (p.type === NodeTypes.ATTRIBUTE) {
       if (dynamicOnly) continue
-      if (p.name === name && p.value && !p.value.isEmpty) {
+      if (p.name === name && p.value) {
         return p
       }
     } else if (
@@ -248,10 +248,6 @@ export function toValidAssetId(
   return `_${type}_${name.replace(/[^\w]/g, '_')}`
 }
 
-export function isEmptyExpression(node: ExpressionNode) {
-  return node.type === NodeTypes.SIMPLE_EXPRESSION && !node.content.trim()
-}
-
 // Check if a node contains expressions that reference current context scope ids
 export function hasScopeRef(
   node: TemplateChildNode | IfBranchNode | ExpressionNode | undefined,