Skip to content

Commit

Permalink
Add fnserver port to docker image (#1507)
Browse files Browse the repository at this point in the history
Docker images have the notion of exposed ports. This indicates the
ports on which a container listens for connections. For the current
fnserver image this is the port 2375 with it inherits from the
fnproject/dind base image.
This confuses end users and other software (reverse proxies) that
expect the fnserver api at this port when inspecting the image/container.

For now it is not possible to remove/unset ports exposed by a base
image but this mr at least adds the default fnserver port to the list
of exposed ports.

https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#expose
  • Loading branch information
jansauer authored and rdallman committed Jun 17, 2019
1 parent 41c598a commit fd27c40
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ FROM fnproject/dind:latest
WORKDIR /app
COPY --from=build-env /tmp/fn-alpine /app/fnserver
CMD ["./fnserver"]
EXPOSE 8080

0 comments on commit fd27c40

Please sign in to comment.