Improved Olympics: Material Design, better layout/scrolling, etc. #101
Conversation
| @@ -30,8 +30,13 @@ foam.CLASS({ | |||
| 'foam.u2.TableView' | |||
| ], | |||
|
|
|||
There was a problem hiding this comment.
The package name of this class should be updated to reflect its new home in come.google.foam.demos
|
I've cut this apart into a |
| @@ -63,6 +63,7 @@ foam.CLASS({ | |||
| properties: [ | |||
| 'data', | |||
| 'action', | |||
| [ 'nodeName', 'button'], | |||
There was a problem hiding this comment.
Keeping this in initE is actually the preferred style.
There was a problem hiding this comment.
Sorry, what? When did that happen?
More importantly, why? Isn't a property you can override more flexible?
There was a problem hiding this comment.
Happened one day in a design meeting.
I think both are equally flexibly, when you extend an element you're probably going to write a custom initE() so you can just set the nodeName there.
I personally like the style of initE() more or less completely defining the element. It also keeps it more consistent when nesting elements. If you have a big block of DSL, you get used to configuring elements though DSL, it becomes an impedance mis-match to configure your element through properties but configure all element you create in initE() through DSL.
That was one of my major pain points with foam U1, was all half the time you had to remember which things to do as properties, which as toHTML, which as toInnerHTML. In U2 its all in initE()
It's why .setNodeName() was added to the DSL.
|
lgtm |
| this.data.select(foam.u2.TableBodySink.create({ properties_: this.properties_ }, this)).then( | ||
| function(a) { this.body = a.body; }.bind(this)); | ||
| var dao = this.data; | ||
| if ( this.sortOrder ) { |
There was a problem hiding this comment.
I feel like the more FOAM way of doing this, would be to make a property called orderedDAO, which is an expression of dao and sortOrder.
There was a problem hiding this comment.
Ignore this for now. If my DAOSlot work pans out we'll be replacing this anyways.
Moves the demo to src/com/google/foam/demos/olympics to be with the others. You need to run `bower update` in the olympics directory before it will work, and you need to use its custom HTML page: polymer.html. The Polymer-powered version is separate from the original, to help demonstrate the changes necessary to add Polymer to an existing app.
No description provided.