Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make visibility icon right #1792

Merged
merged 4 commits into from Jan 15, 2019
Merged

Make visibility icon right #1792

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acf3192
Merge pull request #11 from foam-framework/master
Henry0422 Nov 23, 2018
c6ac58a
Merge pull request #12 from foam-framework/master
Henry0422 Jan 14, 2019
f242f20
Make the visibility icon right
Henry0422 Jan 14, 2019
b919e77
Update the visibilityIcon property
Henry0422 Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/foam/u2/view/PasswordView.js
View file
Open in desktop
Expand Up @@ -36,10 +36,23 @@ foam.CLASS({
}
`,

constants: [
{
type: 'String',
name: 'VISIBILITY',
value: '/foam2/src/foam/u2/images/visibility.svg'
},
{
type: 'String',
name: 'VISIBILITY_OFF',
value: '/foam2/src/foam/u2/images/visibility-off.svg'
}
],

properties: [
{
name: 'visibilityIcon',
value: '/foam2/src/foam/u2/images/visibility.svg'
value: '/foam2/src/foam/u2/images/visibility-off.svg'
Henry0422 marked this conversation as resolved.
Show resolved Hide resolved
},
{
class: 'Boolean',
Expand Down Expand Up @@ -87,13 +100,11 @@ foam.CLASS({
listeners: [
function visible() {
if ( this.passwordInvisible ) {
// Password visible
this.visibleIcon('/foam2/src/foam/u2/images/visibility-off.svg',
'text');
// Make password visible
this.visibleIcon(this.VISIBILITY, 'text');
} else {
// Password invisible
this.visibleIcon('/foam2/src/foam/u2/images/visibility.svg',
'password');
// Make password invisible
this.visibleIcon(this.VISIBILITY_OFF, 'password');
}
}
]
Expand Down