Ignore directories ending in md #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
happy to add the directory check, but I am not comfortable with adding support for other file extensions yet, as there are a couple of places where the extension is assumed to be |
movermeyer
force-pushed
the
mo.ignore_directories_ending_in_md
branch
from
d0aa934
to
c4aabc0
Compare
|
@riccardoferretti I've dropped the commit that extended the list of file extensions. However, it seems that the Windows CI build is failing for unrelated reasons (on both this PR and others). |
|
the issue has been fixed on master, can you rebase? |
movermeyer
force-pushed
the
mo.ignore_directories_ending_in_md
branch
from
c4aabc0
to
fa8d256
Compare
|
@riccardoferretti Looks good now. Thanks! |
riccardoferretti
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
We now check to ensure that the URI is a file (not a directory, etc.).
We also now accept more extensions to be used.