Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on MultiJson #1

Closed
djanowski opened this issue Feb 23, 2015 · 4 comments
Closed

Remove reliance on MultiJson #1

djanowski opened this issue Feb 23, 2015 · 4 comments

Comments

@djanowski
Copy link

In the past I've had gem conflicts because of MultiJson, and, in my opinion, it's not worth to have a dependency on something that is merely a strategy definition.

So instead of depending on it and calling MultiJson.dump (or whatever its API is), you could use something like:

Granola.json = {
  parse: -> str { JSON.parse(str) },
  dump: -> o { o.to_json }
}

What do you think?

@guilleiguaran
Copy link

👍 and about multi_json: intridea/multi_json#113 (comment)

@foca
Copy link
Owner

foca commented Feb 23, 2015

Innnnnnnteresting. Didn't know about the performance problems with MultiJson, it always seemed like a light-enough wrapper that it shouldn't have mattered.

I'll make adjustments ❤️

@foca foca closed this as completed Feb 23, 2015
foca added a commit that referenced this issue Feb 23, 2015
@djanowski
Copy link
Author

👍

@luislavena
Copy link
Contributor

@guilleiguaran @foca performance problems of MultiJson have been removed long ago:

https://gist.github.com/luislavena/17d36542f5dbca83311f

Ruby 2.1.5 and latest version of all gems. data.json is a huge (1K array of hashes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants