Build in background

Do all the building in a new thread, and return control to Sinatra
right away. While a project is building, the project page shows a
'Building...' message with a spinning throbber.

lib/integrity/project.rb

@@ -24,10 +24,14 @@ class Project
     def build(commit_identifier="HEAD")
       return if building?
       update_attributes(:building => true)
-      Builder.new(self).build(commit_identifier)
-    ensure
-      update_attributes(:building => false)
-      send_notifications
+      Thread.new(self) do |project|
+        begin
+          Builder.new(project).build(commit_identifier)
+        ensure
+          project.update_attributes(:building => false)
+          project.send_notifications
+        end
+      end
     end
 
     def last_build
@@ -59,6 +63,12 @@ def notifies?(notifier)
     def enable_notifiers(*args)
       Notifier.enable_notifiers(id, *args)
     end
+
+    def send_notifications
+      notifiers.each do |notifier|
+        notifier.notify_of_build last_build
+      end
+    end
 
     private
       def set_permalink
@@ -73,11 +83,5 @@ def delete_code
         builds.destroy!
         Builder.new(self).delete_code
       end
-
-      def send_notifications
-        notifiers.each do |notifier|
-          notifier.notify_of_build last_build
-        end
-      end
   end
 end

spec/app_spec.rb

@@ -209,6 +209,24 @@
       get_it '/integrity'
       status.should == 404
     end
+
+    describe "displaying a 'building' throbber" do
+      before do
+        Project.stub!(:first).with(:permalink => "integrity").and_return(mock_project)
+      end
+
+      it "should display the throbber when building" do
+        mock_project.stub!(:building?).and_return(true)
+        get_it '/integrity'
+        body.should have_tag("#building_marker", /building/i)
+      end
+
+      it "should not display the throbber when not building" do
+        mock_project.stub!(:building?).and_return(false)
+        get_it '/integrity'
+        body.should_not have_tag("#building_marker")
+      end
+    end
 
     describe 'without builds' do
       before(:each) do

spec/project_spec.rb

@@ -120,6 +120,12 @@ def valid_attributes(attributes={})
       @project = Integrity::Project.new(:uri => @uri, :branch  => 'production', :command  => 'rake spec')
       @builder = mock('Builder', :build => true)
       Integrity::Builder.stub!(:new).and_return(@builder)
+      Thread.stub!(:new).with(@project).and_yield(@project)
+    end
+
+    it "should offload the building to a new thread" do
+      Thread.should_receive(:new).with(@project).and_yield(@project)
+      @project.build
     end
 
     it "should not build if it's already building" do

spec/spec_helper.rb

@@ -94,7 +94,8 @@ def mock_project(messages={})
       :destroy => nil,
       :errors => stub("errors", :on => nil),
       :notifies? => false,
-      :enable_notifiers => nil
+      :enable_notifiers => nil,
+      :building? => true
     }.merge(messages)
 
     @project ||= stub("project", messages)

views/integrity.sass

@@ -351,6 +351,17 @@ a
       .color37
         :color #fff
 
+  #building_marker
+    :position absolute
+    :right 2em
+    :top .8em
+    :padding
+      :top .2em
+      :bottom .2em
+      :right 1.2em
+    :background transparent url(/spinner.gif) no-repeat right
+    :font-weight bold
+
   #push_url
     :display block
     :margin

views/project.haml

@@ -1,6 +1,10 @@
 #administrative
   %a{ :href => project_url(@project, :edit) } Edit Project
 
+- if @project.building?
+  #building_marker
+    Building...
+
 - if @project.builds.empty?
   %form.blank_slate{ :action => project_url(@project, :builds), :method => :post }
     %p No builds for this project, buddy