Typo in NYSE-EURONEXT and missing in HolidayCalendar enum #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But nyse_euronext xml config file has a typo, nsye_euronext.xml And also nyse_euronext is missing from the HoldayCalendar Enum
|
Thanks for your pr. Could you please format the code based on the editorconfig? You could run |
added 2 commits
February 7, 2024 12:42
|
the only difference i could find where the different import orders, i reverted them back to the original one. seems my ide (IDEA) has a different default setting and .editorconfig does not overwrite/define them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my other feature I stumbled over the holidays_nsye_euronext.xml file. There seems to be a typo in the file name should be holidays_nyse_euronext.xml also the file is not mentioned in the HolidayCalendar enum. Not sure if this is on purpose or not.