Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov integration #227

Merged
merged 1 commit into from Dec 21, 2020
Merged

Add codecov integration #227

merged 1 commit into from Dec 21, 2020

Conversation

stefcameron
Copy link
Member

Also adds missing peer dependency on @testing-library/dom for
@testing-library/user-event added in #222.

PR Checklist

Please leave this checklist in your PR.

  • Issue being fixed is referenced.
  • Source changes maintain:
    • Stated browser compatibility.
    • Stated React compatibility.
  • Unit test coverage added/updated.
  • E2E test coverage added/updated.
  • Prop-types added/updated.
  • Typings added/updated.
  • README updated (API changes, instructions, etc.).
  • Changes to dependencies explained.
  • Changeset added (run yarn changeset locally to add one, and follow the prompts).
    • EXCEPTION: A Changeset is not required if the change does not affect any of the source files that produce the package bundle. For example, tooling changes, test updates, or a new dev-only dependency to run tests more efficiently should not have a Changeset since it will not affect package consumers.

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2020

⚠️ No Changeset found

Latest commit: 04f4c17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Also adds missing peer dependency on `@testing-library/dom` for
`@testing-library/user-event` added in #222.
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5983c49). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage          ?   97.14%           
=========================================
  Files             ?        1           
  Lines             ?       70           
  Branches          ?       26           
=========================================
  Hits              ?       68           
  Misses            ?        2           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5983c49...04f4c17. Read the comment docs.

@stefcameron
Copy link
Member Author

I posted this PR before updating the first set of coverage (i.e. base line) from current master so Codecov couldn't report something meaningful here, but we should be good to go for future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant