Fixed stringify()ing numbers. Closes tj#23

focusjs · Jan 26, 2012 · 37416fc · 37416fc
1 parent 3059db3
commit 37416fc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -161,7 +161,7 @@ var stringify = exports.stringify = function(obj, prefix) {
   } else if ('string' == typeof obj) {
     return stringifyString(obj, prefix);
   } else {
-    return prefix;
+    return prefix + '=' + obj;
   }
 };
 
@@ -210,12 +210,14 @@ function stringifyObject(obj, prefix) {
   var ret = []
     , keys = Object.keys(obj)
     , key;
+
   for (var i = 0, len = keys.length; i < len; ++i) {
     key = keys[i];
     ret.push(stringify(obj[key], prefix
       ? prefix + '[' + encodeURIComponent(key) + ']'
       : encodeURIComponent(key)));
   }
+
   return ret.join('&');
 }
 

diff --git a/test/stringify.js b/test/stringify.js
@@ -46,6 +46,10 @@ var qs = require('../')
     'errors': [
       { parsed: 'foo=bar',     message: 'stringify expects an object' },
       { parsed: ['foo', 'bar'], message: 'stringify expects an object' }
+    ],
+    'numbers': [
+      { query_string: 'limit[]=1&limit[]=2&limit[]=3', parsed: { limit: [1, 2, '3'] }},
+      { query_string: 'limit=1', parsed: { limit: 1 }}
     ]
   };
 
@@ -83,6 +87,10 @@ module.exports = {
   'test nested': function() {
     test('nested');
   },
+
+  'test numbers': function(){
+    test('numbers');
+  },
 
   'test errors': function() {
     var parsed, message;