Shindo to minitest - Step 5 #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates baremetal, introspection Also moves /test/openstack/* to /test (seems to be coming from the fog before the split)
Migrates identity, image and planning Requires Pull Request "Shindo to Minitest - Step 2" to be merged first: #118
Migrates metering, nfv, orchestration and volume Adds test/helpers/nfv_helper.rb to share common nvf data Requires Pull Request "Shindo to Minitest - Step 3" to be merged first: #123
Migrates network Requires Pull Request "Shindo to Minitest - Step 4" to be merged first: #124
| module Minitest | ||
| class Test | ||
| # Some tests need to be fixed. There are skipped unless the following is true | ||
| UNIT_TESTS_CLEAN = false.freeze |
There was a problem hiding this comment.
Freezing immutable objects is pointless.
|
Changes Unknown when pulling 7e3c5a1 on gildub:shindo_to_minitest-step_5 into * on fog:master*. |
|
Has been replaced with #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates network
Requires Pull Request "Shindo to Minitest - Step 4" to be merged first:
#124