New bootstraping #413

gildub · 2018-08-15T13:19:37Z

In short, it removes as much as possible any "path" tempering.

Authentication returns a token and its catalog along with all services endpoints available.
When a specific endpoint (among all candidates) is identified, it must be used as it is, without any changes to its path.

There are 2 types of endpoints:

"version based" such as http://192.0.2.6:8774/v2.1
"version less" such as http://192.0.2.6:5000

The difference between those 2 types determines if a prefix is sent along a request.
For example, Nova (https://developer.openstack.org/api-ref/compute/) doesn't prefix any request, beause the endpoint is versionned"

Conversely when a endpoint is "version less" the API provides the version, for example Neutron (https://developer.openstack.org/api-ref/network/v2/)

The default, from now, is to assume a version less endpoint and therefore no prefix is added.
For service with "versioned" endpoint, the service class, for example Fog::Network::OpenStack, will provide the prefix:

   def default_path_prefix
          'v2.0'
    end

Note for reviewers: I'm sorry about this huge Pull Request. I've broken down the effort in multiple commits, although the second one is still big. If that causes too much headache we could eventually use a feature branch.

Note: The new authentication, token and catalog approach is under lib/fog/openstack/auth and takes about 430 lines of code. The respective unit tests under unit/auth are about 845 lines. So altogether we're saving about 200 lines.

houndci-bot · 2018-08-15T13:20:11Z

unit/auth_helper.rb

+          'type' => type,
+          'name' => name }],
+      'user' => { 'username' => 'admin', 'roles_links' => [], 'id' => 'user_id', 'roles' => [{ 'name' => 'admin' }], 'name' => 'admin' },
+      'metadata' => { 'is_admin' => 0, 'roles' => ['role_id'] } } }


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

houndci-bot · 2018-08-15T13:20:11Z

unit/auth_helper.rb

+          'endpoints_links' => [],
+          'type' => type,
+          'name' => name }],
+      'user' => { 'username' => 'admin', 'roles_links' => [], 'id' => 'user_id', 'roles' => [{ 'name' => 'admin' }], 'name' => 'admin' },


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
Metrics/LineLength: Line is too long. [137/120]

houndci-bot · 2018-08-15T13:20:12Z

unit/auth_helper.rb

+            'publicURL' => 'http://localhost' }],
+          'endpoints_links' => [],
+          'type' => type,
+          'name' => name }],


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

houndci-bot · 2018-08-15T13:20:12Z

unit/auth_helper.rb

+            'id' => 'id_endpoints',
+            'publicURL' => 'http://localhost' }],
+          'endpoints_links' => [],
+          'type' => type,


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-15T13:20:12Z

unit/auth_helper.rb

+            'region' => 'regionOne',
+            'internalURL' => 'http://localhost',
+            'id' => 'id_endpoints',
+            'publicURL' => 'http://localhost' }],


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

houndci-bot · 2018-08-15T13:20:13Z

unit/auth_helper.rb

+      { 'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',
+        'id' => '4ae647d3a5294690a3c29bc658e17e26',
+        'tenant' => { 'description' => 'admin tenant', 'enabled' => true, 'id' => 'tenant_id', 'name' => 'admin' },


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

houndci-bot · 2018-08-15T13:20:13Z

unit/auth_helper.rb

+    { 'token' =>
+      { 'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',
+        'id' => '4ae647d3a5294690a3c29bc658e17e26',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-15T13:20:13Z

unit/auth_helper.rb

+  { 'access' =>
+    { 'token' =>
+      { 'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-15T13:20:13Z

unit/auth_helper.rb

+def auth_response_v2(type, name)
+  { 'access' =>
+    { 'token' =>
+      { 'issued_at' => '2017-12-05T10:44:31.454741Z',


Layout/SpaceInsideHashLiteralBraces: Space inside { detected.

houndci-bot · 2018-08-15T13:20:14Z

unit/auth_helper.rb

+
+def auth_response_v2(type, name)
+  { 'access' =>
+    { 'token' =>


Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

theopenlab-ci · 2018-08-15T13:35:08Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 14m 12s
fog-openstack-unittest-spec : SUCCESS in 12m 48s

houndci-bot · 2018-08-16T00:09:10Z

unit/auth_helper.rb

+          'name' => 'admin'
+        }], 'name' => 'admin'
+      },
+      'metadata' => {


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:10Z

unit/auth_helper.rb

+        'type' => type,
+        'name' => name
+      }],
+      'user' => {


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:10Z

unit/auth_helper.rb

+        }],
+        'endpoints_links' => [],
+        'type' => type,
+        'name' => name


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:10Z

unit/auth_helper.rb

+          'publicURL' => 'http://localhost'
+        }],
+        'endpoints_links' => [],
+        'type' => type,


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:10Z

unit/auth_helper.rb

+          'region' => 'regionOne',
+          'internalURL' => 'http://localhost',
+          'id' => 'id_endpoints',
+          'publicURL' => 'http://localhost'


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:11Z

unit/auth_helper.rb

+        'id' => '4ae647d3a5294690a3c29bc658e17e26',
+        'tenant' => {
+          'description' => 'admin tenant',
+          'enabled' => true,


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:12Z

unit/auth_helper.rb

+        'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',
+        'id' => '4ae647d3a5294690a3c29bc658e17e26',
+        'tenant' => {


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:12Z

unit/auth_helper.rb

+      'token' => {
+        'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',
+        'id' => '4ae647d3a5294690a3c29bc658e17e26',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:12Z

unit/auth_helper.rb

+    'access' => {
+      'token' => {
+        'issued_at' => '2017-12-05T10:44:31.454741Z',
+        'expires' => '2017-12-05T11:44:31Z',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:09:12Z

unit/auth_helper.rb

+def auth_response_v2(type, name)
+  {
+    'access' => {
+      'token' => {


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T00:20:03Z

unit/auth_helper.rb

+  }
+end
+
+def auth_response_v2(type, name)


Metrics/MethodLength: Method has too many lines. [41/25]

houndci-bot · 2018-08-16T00:20:03Z

unit/auth_helper.rb

+            'interface' => 'admin',
+            'id'        => 'id_endpoint_admin'
+          }
+        ],


Layout/MultilineArrayBraceLayout: Closing array brace must be on the same line as the last array element when opening brace is on the same line as the first array element.

houndci-bot · 2018-08-16T00:20:04Z

unit/auth_helper.rb

+            'interface' => 'public',
+            'id'        => 'id_endpoint_public'
+          },
+          {


Layout/AlignArray: Align the elements of an array literal if they span more than one line.

houndci-bot · 2018-08-16T00:20:04Z

unit/auth_helper.rb

+            'interface' => 'internal',
+            'id'        => 'id_endpoint_internal'
+          },
+          {


Layout/AlignArray: Align the elements of an array literal if they span more than one line.

houndci-bot · 2018-08-16T00:20:04Z

unit/auth_helper.rb

+            'region'    => 'regionOne',
+            'interface' => 'internal',
+            'id'        => 'id_endpoint_internal'
+          },


Layout/IndentHash: Indent the right brace the same as the start of the line where the left brace is.

houndci-bot · 2018-08-16T00:20:04Z

unit/auth_helper.rb

@@ -0,0 +1,101 @@
+def auth_response_v3(type, name)


Metrics/MethodLength: Method has too many lines. [55/25]

houndci-bot · 2018-08-16T00:20:04Z

unit/auth/token_test.rb

+
+      it '#get_endpoint_url' do
+        stub_request(:post, 'http://localhost/identity/v2.0/tokens').
+          to_return(:status => 200, :body => JSON.dump(auth_response_v2('identity', 'keystone')), :headers => {'x-subject-token'=>'token_data'})


Metrics/LineLength: Line is too long. [144/120]

houndci-bot · 2018-08-16T00:20:05Z

unit/auth/token_test.rb

+
+      it '#catalog' do
+        stub_request(:post, 'http://localhost/identity/v2.0/tokens').
+          to_return(:status => 200, :body => "{\"access\":{\"token\":{\"id\":\"token_data\"},\"serviceCatalog\":[\"catalog_data\"]}}", :headers => {})


Metrics/LineLength: Line is too long. [150/120]

houndci-bot · 2018-08-16T00:20:05Z

unit/auth/token_test.rb

+
+        it 'when token has expired' do
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens').
+            to_return(:status => 200, :body => "{\"access\":{\"token\":{\"id\":\"token_expired\"},\"serviceCatalog\":[\"catalog_data\"]}}", :headers => {})


Metrics/LineLength: Line is too long. [155/120]

houndci-bot · 2018-08-16T00:20:05Z

unit/auth/token_test.rb

+      describe '#get' do
+        it 'when token has not expired' do
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens').
+            to_return(:status => 200, :body => "{\"access\":{\"token\":{\"id\":\"token_not_expired\"},\"serviceCatalog\":[\"catalog_data\"]}}", :headers => {})


Metrics/LineLength: Line is too long. [159/120]

theopenlab-ci · 2018-08-16T00:32:48Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 11m 55s
fog-openstack-unittest-spec : SUCCESS in 12m 26s

houndci-bot · 2018-08-16T04:34:16Z

test/microversion_test.rb

@@ -2,12 +2,13 @@

 describe "when microversion" do
  before do
-    @microversion_tester = TestMicroVersion.new
+    @microversion_tester = Object.new
+    @microversion_tester = extend(Fog::OpenStack::Core)


Style/MixinUsage: extend is used at the top level. Use inside class or module.

houndci-bot · 2018-08-16T04:34:16Z

spec/volume_spec.rb

+
+            # check that the transfer object is gone on both sides
+            [@service, other_service].each do |service|
+              assert_nil service.transfers.get(transfer.id)


Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.

houndci-bot · 2018-08-16T04:34:16Z

spec/volume_spec.rb

+            volume.tenant_id.wont_equal(source_tenant_id)
+
+            # check that the transfer object is gone on both sides
+            [@service, other_service].each do |service|


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:16Z

spec/volume_spec.rb

+            # As noted above, both users seem to be able to see the volume at all times.
+            # Check change of ownership by looking at the tenant_id, instead.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID
+            volume.tenant_id.wont_equal(source_tenant_id)


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:16Z

spec/volume_spec.rb

+
+            # As noted above, both users seem to be able to see the volume at all times.
+            # Check change of ownership by looking at the tenant_id, instead.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:17Z

spec/volume_spec.rb

+            proc { other_service.transfers.accept(transfer_id, 'invalidauthkey') }.must_raise Excon::Errors::BadRequest
+
+            # accept transfer
+            puts 'Accepting transfer...' if ENV['DEBUG_VERBOSE']


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:17Z

spec/volume_spec.rb

+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR
+            proc { other_service.transfers.accept(bogus_uuid, auth_key) }.must_raise Fog::Volume::OpenStack::NotFound
+            proc { other_service.transfers.accept(transfer_id, 'invalidauthkey') }.must_raise Excon::Errors::BadRequest


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:17Z

spec/volume_spec.rb

+
+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR
+            proc { other_service.transfers.accept(bogus_uuid, auth_key) }.must_raise Fog::Volume::OpenStack::NotFound


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:17Z

spec/volume_spec.rb

+            source_tenant_id = volume.tenant_id
+
+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:17Z

spec/volume_spec.rb

+            # The recipient can inexplicably see the volume even before the
+            # transfer, so to confirm that the transfer happens, we record its tenant ID.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID
+            source_tenant_id = volume.tenant_id


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:18Z

test/microversion_test.rb

@@ -2,12 +2,13 @@

 describe "when microversion" do
  before do
-    @microversion_tester = TestMicroVersion.new
+    @microversion_tester = Object.new
+    @microversion_tester = extend(Fog::OpenStack::Core)


Style/MixinUsage: extend is used at the top level. Use inside class or module.

houndci-bot · 2018-08-16T04:34:18Z

spec/volume_spec.rb

+
+            # check that the transfer object is gone on both sides
+            [@service, other_service].each do |service|
+              assert_nil service.transfers.get(transfer.id)


Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.

houndci-bot · 2018-08-16T04:34:18Z

spec/volume_spec.rb

+            volume.tenant_id.wont_equal(source_tenant_id)
+
+            # check that the transfer object is gone on both sides
+            [@service, other_service].each do |service|


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:18Z

spec/volume_spec.rb

+            # As noted above, both users seem to be able to see the volume at all times.
+            # Check change of ownership by looking at the tenant_id, instead.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID
+            volume.tenant_id.wont_equal(source_tenant_id)


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:19Z

spec/volume_spec.rb

+
+            # As noted above, both users seem to be able to see the volume at all times.
+            # Check change of ownership by looking at the tenant_id, instead.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:19Z

spec/volume_spec.rb

+            proc { other_service.transfers.accept(transfer_id, 'invalidauthkey') }.must_raise Excon::Errors::BadRequest
+
+            # accept transfer
+            puts 'Accepting transfer...' if ENV['DEBUG_VERBOSE']


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:19Z

spec/volume_spec.rb

+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR
+            proc { other_service.transfers.accept(bogus_uuid, auth_key) }.must_raise Fog::Volume::OpenStack::NotFound
+            proc { other_service.transfers.accept(transfer_id, 'invalidauthkey') }.must_raise Excon::Errors::BadRequest


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:20Z

spec/volume_spec.rb

+
+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR
+            proc { other_service.transfers.accept(bogus_uuid, auth_key) }.must_raise Fog::Volume::OpenStack::NotFound


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:20Z

spec/volume_spec.rb

+            source_tenant_id = volume.tenant_id
+
+            # check that accept_transfer fails without valid transfer ID and auth key
+            bogus_uuid = 'ec8ff7e8-81e2-4e12-b9fb-3e8890612c2d' # from Fog::UUID.uuid, but fixed to play nice with VCR


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-08-16T04:34:20Z

spec/volume_spec.rb

+            # The recipient can inexplicably see the volume even before the
+            # transfer, so to confirm that the transfer happens, we record its tenant ID.
+            volume.tenant_id.must_match(/^[0-9a-f-]+$/) # should look like a UUID
+            source_tenant_id = volume.tenant_id


Layout/IndentationConsistency: Inconsistent indentation detected.

theopenlab-ci · 2018-08-16T04:54:44Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 20m 27s
fog-openstack-unittest-spec : SUCCESS in 12m 21s

houndci-bot · 2018-08-16T05:52:12Z

lib/fog/orchestration/openstack.rb

@@ -123,8 +119,7 @@ def credentials
          {:provider                    => 'openstack',
           :openstack_auth_url          => @openstack_auth_uri.to_s,
           :openstack_auth_token        => @auth_token,
-           :openstack_management_url    => @openstack_management_url,
-           :openstack_identity_endpoint => @openstack_identity_public_endpoint}
+           :openstack_management_url    => @openstack_management_url}


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-16T05:52:12Z

lib/fog/openstack/auth/token/v2.rb

+            }
+          end
+
+          def set(response)


Metrics/AbcSize: Assignment Branch Condition size for set is too high. [17.49/15]

houndci-bot · 2018-08-16T05:52:12Z

lib/fog/openstack/auth/token/v2.rb

+          include Fog::OpenStack::Auth::Token
+          attr_reader :tenant
+
+          def credentials


Metrics/AbcSize: Assignment Branch Condition size for credentials is too high. [16.31/15]
Metrics/PerceivedComplexity: Perceived complexity for credentials is too high. [8/7]

houndci-bot · 2018-08-16T05:52:12Z

lib/fog/openstack/auth/token/v3.rb

+            end
+          end
+
+          def build_credentials(auth)


Metrics/AbcSize: Assignment Branch Condition size for build_credentials is too high. [41.7/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for build_credentials is too high. [14/6]
Metrics/MethodLength: Method has too many lines. [44/25]
Metrics/PerceivedComplexity: Perceived complexity for build_credentials is too high. [18/7]

houndci-bot · 2018-08-16T05:52:12Z

lib/fog/openstack/core.rb

+        @persistent = options[:persistent] || false
+      end
+
+      def authenticate


Metrics/AbcSize: Assignment Branch Condition size for authenticate is too high. [22.23/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for authenticate is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [26/25]
Metrics/PerceivedComplexity: Perceived complexity for authenticate is too high. [9/7]

houndci-bot · 2018-08-16T05:52:13Z

unit/auth/token_test.rb

+
+        it 'when token has expired' do
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .to_return(


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T05:52:14Z

unit/auth/token_test.rb

+      describe '#get' do
+        it 'when token has not expired' do
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .to_return(


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T05:52:14Z

unit/auth/token_test.rb

+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"token\":{\"id\":\"token_id\"},\"tenantId\":\"tenant_id\"}}")
+            .to_return(:status => 200, :body => JSON.dump(auth_response_v2('identity', 'keystone')), :headers => {})


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T05:52:14Z

unit/auth/token_test.rb

+          }
+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"token\":{\"id\":\"token_id\"},\"tenantId\":\"tenant_id\"}}")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T05:52:14Z

unit/auth/token_test.rb

+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"token\":{\"id\":\"token_id\"},\"tenantName\":\"tenant\"}}")
+            .to_return(:status => 200, :body => JSON.dump(auth_response_v2('identity', 'keystone')), :headers => {})


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

theopenlab-ci · 2018-08-16T06:06:05Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 12m 34s
fog-openstack-unittest-spec : SUCCESS in 13m 32s

houndci-bot · 2018-08-16T06:51:53Z

unit/auth/token_test.rb

+          }
+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"token\":{\"id\":\"token_id\"},\"tenantName\":\"tenant\"}}")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:53Z

unit/auth/token_test.rb

+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"passwordCredentials\":{\"username\":\"user\",\"password\":\"secret\"},\
+\"tenantId\":\"tenant_id\"}}")
+            .to_return(:status => 200, :body => JSON.dump(auth_response_v2('identity', 'keystone')), :headers => {})


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:54Z

unit/auth/token_test.rb

+          }
+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"passwordCredentials\":{\"username\":\"user\",\"password\":\"secret\"},\


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:54Z

unit/auth/token_test.rb

+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"passwordCredentials\":{\"username\":\"user\",\"password\":\"secret\"},\
+\"tenantName\":\"tenant\"}}")
+            .to_return(:status => 200, :body => JSON.dump(auth_response_v2('identity', 'keystone')), :headers => {})


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:54Z

unit/auth/token_test.rb

+          }
+
+          stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+            .with(:body => "{\"auth\":{\"passwordCredentials\":{\"username\":\"user\",\"password\":\"secret\"},\


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:54Z

unit/auth/token_test.rb

+    describe '#new' do
+      it 'fails when missing credentials' do
+        stub_request(:post, 'http://localhost/identity/v2.0/tokens')
+          .to_return(:status => 200, :body => "{\"access\":{\"token\":{\"id\":\"token_data\"}}}", :headers => {})


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T06:51:54Z

unit/auth/token_test.rb

+
+      it '#get_endpoint_url' do
+        stub_request(:post, 'http://localhost/identity/v3/auth/tokens')
+          .to_return(


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-08-16T07:01:26Z

test/authenticate_tests.rb

+    service = Object.new
+    service.extend(Fog::OpenStack::Core)
+    service.send(:setup,
+      :openstack_auth_url     => 'http://example',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.

houndci-bot · 2018-08-16T07:01:26Z

test/authenticate_tests.rb

+      :openstack_api_key      => 'secret',
+      :openstack_username     => 'user',
+      :openstack_service_type => 'object-store'
+    )


Layout/ClosingParenthesisIndentation: Align ) with (.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.

houndci-bot · 2018-08-16T07:01:26Z

test/authenticate_tests.rb

+    service = Object.new
+    service.extend(Fog::OpenStack::Core)
+    service.send(:setup,
+      :openstack_auth_url     => 'http://example',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.

houndci-bot · 2018-08-16T07:01:27Z

test/authenticate_tests.rb

+      :openstack_service_type => %w[network],
+      :openstack_api_key      => 'secret',
+      :openstack_username     => 'user'
+    )


Layout/ClosingParenthesisIndentation: Align ) with (.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.

houndci-bot · 2018-08-16T07:01:27Z

test/authenticate_tests.rb

+    service = Object.new
+    service.extend(Fog::OpenStack::Core)
+    service.send(:setup,
+      :openstack_auth_url     => 'http://example',


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.

houndci-bot · 2018-08-16T07:01:27Z

spec/image_v2_spec.rb

+    if image_id
+      begin
+        image_by_id = @service.images.find_by_id(image_id)
+      rescue


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2018-08-16T07:04:41Z

lib/fog/openstack/auth/catalog/v3.rb

+            end
+          end
+
+          def endpoint_url(endpoint, _)


Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

houndci-bot · 2018-08-16T07:04:41Z

lib/fog/openstack/auth/catalog.rb

+          @payload = payload
+        end
+
+        def get_endpoint_url(names, interfaces, region = nil)


Metrics/PerceivedComplexity: Perceived complexity for get_endpoint_url is too high. [8/7]

houndci-bot · 2018-08-16T07:04:41Z

lib/fog/openstack.rb

+      # Clear version suffix from path
+      # This is needed because when catalog endpoint is not top level
+      # or '/' to allow version discovery
+      path = uri.path.gsub(/\/v([1-9]+\d*)(\.[1-9]+\d*)*.*$/, '/')


Style/RegexpLiteral: Use %r around regular expression.

theopenlab-ci · 2018-08-16T07:17:01Z

Build failed.

fog-openstack-unittest-test : SUCCESS in 12m 10s
fog-openstack-unittest-spec : FAILURE in 3m 49s

houndci-bot · 2018-08-16T07:22:45Z

spec/image_v2_spec.rb

+    if image_id
+      begin
+        image_by_id = @service.images.find_by_id(image_id)
+      rescue


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2018-08-16T07:26:49Z

lib/fog/openstack.rb

@@ -566,27 +153,21 @@ def self.get_supported_microversion(supported_versions, uri, auth_token, connect

    # CGI.escape, but without special treatment on spaces
    def self.escape(str, extra_exclude_chars = '')
-      str.gsub(/([^a-zA-Z0-9_.-#{extra_exclude_chars}]+)/) do
+      str.gsub(%r{([^a-zA-Z0-9_.-#{extra_exclude_chars}]+)}) do


Style/RegexpLiteral: Use // around regular expression.

houndci-bot · 2018-08-16T07:30:36Z

test/authenticate_tests.rb

+      :openstack_tenant       => 'admin',
+      :openstack_api_key      => 'secret',
+      :openstack_username     => 'user',
+      :openstack_service_type => 'compute')


Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

houndci-bot · 2018-08-16T07:30:36Z

test/authenticate_tests.rb

@@ -178,39 +178,21 @@

    Excon.stub(
      {:method => 'POST', :path => "/v2.0/tokens"},
-      {:status => 200, :body => Fog::JSON.encode(body_clone)}
-    )
+      {:status => 200, :body => Fog::JSON.encode(body_clone)})


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

houndci-bot · 2018-08-16T07:30:36Z

test/authenticate_tests.rb

+      :openstack_tenant       => 'admin',
+      :openstack_api_key      => 'secret',
+      :openstack_username     => 'user',
+      :openstack_service_type => 'object-store')


Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

houndci-bot · 2018-08-16T07:30:36Z

test/authenticate_tests.rb

+      :openstack_tenant       => 'admin',
+      :openstack_service_type => %w[network],
+      :openstack_api_key      => 'secret',
+      :openstack_username     => 'user')


Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

houndci-bot · 2018-08-16T07:30:36Z

test/authenticate_tests.rb

-      {:status => 200, :body => Fog::JSON.encode(@body)}
-    )
-
+      {:status => 200, :body => Fog::JSON.encode(@body)})


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

houndci-bot · 2018-08-16T07:30:37Z

test/authenticate_tests.rb

    }

    assert(expected) do
      Fog::OpenStack.authenticate_v2(
        :openstack_auth_uri     => URI('http://example/v2.0/tokens'),
        :openstack_tenant       => 'admin',
-        :openstack_service_type => %w[compute]
-      )
+        :openstack_service_type => %w[compute])


Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

theopenlab-ci · 2018-08-16T07:47:27Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 14m 22s
fog-openstack-unittest-spec : SUCCESS in 13m 53s

theopenlab-ci · 2018-08-17T05:50:12Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 13m 48s
fog-openstack-unittest-spec : SUCCESS in 12m 44s

theopenlab-ci · 2018-08-17T10:29:09Z

Build failed.

fog-openstack-unittest-test : SUCCESS in 12m 19s
fog-openstack-unittest-spec : FAILURE in 5m 40s

theopenlab-ci · 2018-08-17T11:18:33Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 11m 53s
fog-openstack-unittest-spec : SUCCESS in 16m 18s

houndci-bot · 2018-08-21T07:43:12Z

lib/fog/compute/openstack/requests/create_server.rb

@@ -94,7 +94,7 @@ def create_server(name, image_ref, flavor_ref, options = {})
          response.status = 202

          server_id = Fog::Mock.random_numbers(6).to_s
-          identity = Fog::Identity::OpenStack.new :openstack_auth_url => credentials[:openstack_auth_url]
+          identity = Fog::Identity::OpenStack.new(:openstack_auth_url => credentials[:openstack_auth_url], :openstack_api_version => 'v2.0')


Metrics/LineLength: Line is too long. [140/120]

theopenlab-ci · 2018-08-21T07:57:03Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 12m 08s
fog-openstack-unittest-spec : SUCCESS in 13m 43s

houndci-bot · 2018-08-21T23:41:59Z

test/authenticate_tests.rb

-    Fog.credentials = {:openstack_auth_url => 'http://openstack:35357/v2.0/tokens'}
-    identity = Fog::Identity[:openstack]
+    creds = {
+      :openstack_auth_url => 'http://openstack:35357',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-21T23:41:59Z

test/authenticate_tests.rb

-    Fog.credentials = {:openstack_auth_url => 'http://openstack:35357/v2.0/tokens'}
-    identity = Fog::Identity[:openstack]
+    creds = {
+      :openstack_auth_url => 'http://openstack:35357',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

houndci-bot · 2018-08-21T23:41:59Z

test/authenticate_tests.rb

        :openstack_tenant       => 'admin',
-        :openstack_service_type => %w[compute]
-      )
+        :openstack_service_type => %w[compute])


Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

theopenlab-ci · 2018-08-21T23:57:31Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 15m 15s
fog-openstack-unittest-spec : SUCCESS in 12m 21s

houndci-bot · 2018-08-22T05:16:34Z

test/authenticate_tests.rb

-    Fog.credentials = {:openstack_auth_url => 'http://openstack:35357/v2.0/tokens'}
-    identity = Fog::Identity[:openstack]
+    creds = {
+      :openstack_auth_url => 'http://openstack:35357',


Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

theopenlab-ci · 2018-08-22T05:38:03Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 21m 18s
fog-openstack-unittest-spec : SUCCESS in 21m 24s

liusheng · 2018-08-23T02:31:17Z

recheck

theopenlab-ci · 2018-08-23T02:49:15Z

Build succeeded.

fog-openstack-unittest-test : SUCCESS in 12m 59s
fog-openstack-unittest-spec : SUCCESS in 17m 14s

Ladas

👍 looks great, I like the idea but I haven't tested it

@aufi can you test it? We should probably bump a minor version releasing this

aufi · 2018-08-27T07:52:00Z

Tested manually on Queens Packstack installation with some of examples/ scripts and does not work for me.

Example for https://github.com/fog/fog-openstack/blob/master/examples/metric/basics.rb#L4

Works good if AUTH_URL contains endpoint without path. Fails if a path is present, see http://paste.openstack.org/show/728812/

If the I tested it in wrong way, please, let me know, thanks!

gildub · 2018-08-27T09:08:55Z

@aufi,

Yes the path shouldn't contain 'v3' or 'v2.0' or any 'tokens/auth' or 'such `path.
The default endpoint provided by Openstack identity should work assuming it's version less.

aufi · 2018-08-28T08:02:43Z

Thanks Gilles for the PR, I think it is a big step forward, I'm going to merge it.

As discussed, error with path in AUTH_URL can be addressed in follow-up PR.

gildub · 2018-08-28T08:09:49Z

Thanks @aufi

houndci-bot reviewed Aug 15, 2018

View reviewed changes

gildub mentioned this pull request Aug 15, 2018

A fog-openstack with a more "version less" approach ManageIQ/manageiq-providers-openstack#334

Merged

gildub mentioned this pull request Aug 15, 2018

[openstack][pike] Compute[:openstack].servers doesn't work #362

Closed

houndci-bot reviewed Aug 16, 2018

View reviewed changes

houndci-bot reviewed Aug 21, 2018

View reviewed changes

gildub added 5 commits August 22, 2018 09:39

New authentication and catalog structure

833a843

Refactors bootstraping

cfca6a7

Cleanup: identity_public_endpoint and compute/list_tenants

7afa481

authentication is done by fog/openstack/auth

6044f23

options consolidaton; default_service_type as method

67e5204

gildub added 10 commits August 22, 2018 09:39

not default prefix for nova

fdc7506

remove ssl_verify_mode not needed for Excon

cd8c123

Swift: using new bootstrap too

33afcc1

Use super for shared_file_system and storage too

f379dab

Fog::OpenStack::Core.authenticate: final cleanup

a75e5cb

Readjust some authenticate tests

f9884ad

tests: rename jobs and beautify

6e78243

fix rubocop including legacy

b1d602d

fix after rebase

fe0c04c

typo

a7fc03c

houndci-bot reviewed Aug 21, 2018

View reviewed changes

identity: version from param not url

ebfbd6c

houndci-bot reviewed Aug 22, 2018

View reviewed changes

Ladas approved these changes Aug 23, 2018

View reviewed changes

aufi merged commit d4ac99c into fog:master Aug 28, 2018

aufi added the refactoring label Aug 28, 2018

gildub deleted the new-bootstraping branch August 28, 2018 08:09

New bootstraping #413

New bootstraping #413

Conversation

gildub commented Aug 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theopenlab-ci bot commented Aug 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theopenlab-ci bot commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theopenlab-ci bot commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theopenlab-ci bot commented Aug 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gildub commented Aug 15, 2018 •

edited

Loading