Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead code in OpenStack tests #2799

Closed
L2G opened this issue Mar 29, 2014 · 5 comments
Closed

Dead code in OpenStack tests #2799

L2G opened this issue Mar 29, 2014 · 5 comments

Comments

@L2G
Copy link
Contributor

L2G commented Mar 29, 2014

I spotted some dead code in tests/openstack/requests/network/router_tests.rb. Please see my notes on commit 55cffa7 for details.
L2G added a commit to L2G/fog that referenced this issue Mar 31, 2014
@L2G
Trial fix for fog#2799 - tests fail
f7745ae
@L2G
Copy link
Contributor Author

L2G commented Mar 31, 2014

@geemus asked for a copy of the broken-test output on Gist, so... https://gist.github.com/L2G/03f602b467660bc02aab

@geemus
Copy link
Member

geemus commented Apr 1, 2014

Thanks!

@krames - could you help sort this out/land this? Thanks!

@krames
Copy link
Member

krames commented Apr 1, 2014

@geemus looking into it now.

krames pushed a commit to rackspace/fog that referenced this issue Apr 1, 2014
[openstack|network] updated create_router and update_router use symbo…
2f5d0ef 
…l based keys instead of string; removed dead code; this should address fog#2799
@krames krames mentioned this issue Apr 1, 2014
Merged
@krames
Copy link
Member

krames commented Apr 2, 2014

This issue should be fixed in the latest master. Please feel free to reopen this issue if you are still having problems.

@krames krames closed this as completed Apr 2, 2014
@geemus
Copy link
Member

geemus commented Apr 2, 2014

Thanks!

On Wed, Apr 2, 2014 at 2:14 PM, Kyle Rames notifications@github.com wrote:

Closed #2799 #2799.

Reply to this email directly or view it on GitHubhttps://github.com//issues/2799
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@geemus @L2G @krames