Moves Fog::VERSION to fog/core, Adds User-Agent header #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now available within "fog/core" Just reverted a change where depending on Fog::VERSION for the User-Agent made a dependency on requiring "lib/fog" which also requires all providers and services. That is highly undesirable from a modular perspective!
|
@tokengeek - I believe |
No longer need to read in `lib/fog` to access the VERSION mostly because we are already requiring it anyway in the Rakefile! The #version method just repeats Fog::VERSION `rake -T` works and changelog generates
|
@geemus Fixed that. We required "lib/fog" anyway so had access to So |
|
@tokengeek - cool, fair enough, just wanted to double check. |
|
@geemus Happy to merge? |
|
@tokengeek - oh, yeah, sorry for ambiguity. Go for it, thanks! |
tokengeek
added a commit
that referenced
this pull request
Nov 27, 2012
Moves Fog::VERSION to fog/core, Adds User-Agent header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #1310
Fog::VERSIONis now in it's own file which is required from withinlib/fog/coreso should be available to individual providers without needing to bring in everything inlib/fogLazily this also includes the change to add the User-Agent header