[rackspace] fixing broken tests #1918
Conversation
…ntil I can get them fixed
…to add in testing
… specific hard coded timeouts.
|
|
||
|
|
||
| unless Fog.mocking? | ||
| Fog.timeout = 2000 |
There was a problem hiding this comment.
@geemus I don't know if this is the best place to make this change or if this is even a change we want to make. Thoughts?
There was a problem hiding this comment.
Good question. It might point to us needing a longer default timeout in general (ie most people are running live stuff, so if the timeout is only good for mock it isn't very good at all).
There was a problem hiding this comment.
I think your right. I know I have seen this issue popup in knife-rackspace more times than it should have.
What do you think about increasing the default timeout in fog to 1000 (~16 minutes)? I would still like to keep the testing timeout to 2000. Do you think I should relocate this line to fog test helper file?
There was a problem hiding this comment.
Any reason why the testing one would be expected to be twice as long? I'm ok with increasing the default if we think that needs to occur. I guess it might hint that a per-provider default might be worth pursuing (as I haven't heard about this issue from other providers, which of course doesn't mean it isn't happening).
There was a problem hiding this comment.
I wanted to give the testing environment more than enough time to complete an operation without having to worry about getting a timeout exception. Outside of testing, I can foresee a developer wanting to get a timeout sooner than 2000 (33 minutes) and having the code to handle it accordingly. Maybe I am wrong?
There was a problem hiding this comment.
Probably fair. I had just wondered why this might be exceptional compared to real usage (since ideally the tests mimic real usage to some extent). Makes sense though.
[rackspace] fixing broken tests
This pull request address several issues that occur when run against the live Rackspace Cloud.
I have also increased the default fog timeout to 2000 seconds when running tests against a live cloud to address the brittleness of the Rackspace tests. I am receptive to hearing everyone's thoughts on this change.