Fix distributed port group switches support for cloning with multiple networks #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… networks We were not passing the datacenter parameter when searching for networks, which caused issues when searching for distributed switches attributes
This allows to specify the virtualswitch value for the network interface based on the network data.
|
@nirvdrum could you take a peak when you have a moment? Thanks! |
|
@nirvdrum This is holding up a feature in Foreman, theforeman/foreman#2714, would you mind taking a look? Thanks! |
|
Sorry, I missed the first ping. Just to set expectations, I probably won't be able to look at this until the weekend. |
| :name => network.name, | ||
| :accessible => network.summary.accessible, | ||
| :datacenter => datacenter, | ||
| :virtualswitch => network.class.to_s == "DistributedVirtualPortgroup" ? network.config.distributedVirtualSwitch.name : nil |
There was a problem hiding this comment.
We can fix this after, but calling class.to_s seems like an odd pattern to me. class.name is the typical way I've seen things done like this.
nirvdrum
added a commit
that referenced
this pull request
Oct 21, 2015
Fix distributed port group switches support for cloning with multiple networks
|
@nirvdrum Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not passing the datacenter parameter when searching for networks,
which caused issues when searching for distributed switches attributes
Also, I've extracted the virtualswitch parameter to the network model,
which allows to specify the virtualswitch value for the network interface
based on the network data later. Our workflow is letting the user
to choose what network should be the nic attached to and then creating
the networks correspondingly and we use the network object for that.