[compute|aws] - Change modify_instance_attribute name to match EC2 API me #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I method, and actually make it do something
|
Great, thanks for the cleanup! |
geemus
added a commit
that referenced
this pull request
Aug 31, 2011
[compute|aws] - Change modify_instance_attribute name to match EC2 API me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method doesn't really do anything, so make it work.
As well, the EC2 API method is '_attribute', and the filename is '_attribute', and the two other similar methods are '_attribute', but for some reason this method got named '_attributes'. Fix that, and add a depcrecation warning to the old method.