Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to traverseda/PyCraft #71

Closed
traverseda opened this issue Apr 9, 2016 · 3 comments
Closed

Link to traverseda/PyCraft #71

traverseda opened this issue Apr 9, 2016 · 3 comments

Comments

@traverseda
Copy link

https://github.com/traverseda/PyCraft

A lot of people are interested in your project, and there are a lot of forks.

I've cloned your repo, with the intent of being a lot more accepting of pull requests. We've already got the start of an object-oriented block system and a perlin noise based terrain generator.

There's a lot of interesting stuff people could do with this project, but most of them would hurt the intent. Would make it less useful as a teaching tool, and obviously would push the line count waay higher.

I don't mind submitting a pull request, but I wanted to make sure you're amenable to this kind of thing before doing it.

@progval
Copy link
Contributor

progval commented Apr 9, 2016

The author answered a similar question: #66 (comment)

@traverseda
Copy link
Author

Thanks, I appreciate it, and am definitely going to look through that code and see if it supersedes the OO blocks that I've been working on.

This is more about policy though. I'd like it, if instead of saying "it's better for it to remain separate" the answer was "that looks like the kind of pull request PyCraft is looking for".

That way we can consolidate some cool features, like that one.

@traverseda
Copy link
Author

I've gotten a bunch of pull requests, it really looks like it's starting to take shape. Just give the word and I'll submit a PR directing people towards traverseda/pycraft it they want to improve the engine.

Probably a blurb like

This repository is meant for education, and accepts pull requests that help it do that.

If you want to contribute to something more permissive, check out pycraft

@fogleman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants