-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object oriented version with text visualization #66
Conversation
Sorry it can't be automatically merged... I tried to keep this version as close as I could from the original repo. If you test and look at the code, you may feel safe to accept it all as it is. |
Nice work. Instead of merging, I think it is best for the fork to remain separate. There is some value in the original project as it is < 1000 lines and more approachable by people who want to learn. Yours can be further developed to have more features and be more API-like. |
Thanks for the feedback! I'll keep working on it as an independent repo, then. |
I started out trying to detach objects to create an API as suggested in the project vision, but it grew a little bigger.
I've managed to create a few classes and a few unit tests. And then I realized the world object could be used with different ways of rendering, so I tried it out.
I'm on my way into evolving that even further, but I thought I should reach for a pull request so that my code doesn't go too far from here as it would become impossible to merge.
I also managed to make it Python 2 and 3 compatible. I messed up my PEP8 efforts, but they will come back in future commits.