MODFQMMGR-202: Include system exchange rate in Lists app #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvsharp
force-pushed
the
MODFQMMGR-202-master
branch
2 times, most recently
from
82555d9
to
496790d
Compare
bvsharp
commented
Mar 29, 2024
Comment on lines
+48
to
+81
| static final List<String> SYSTEM_SUPPORTED_CURRENCIES = List.of( | ||
| "USD", | ||
| "JPY", | ||
| "BGN", | ||
| "CZK", | ||
| "DKK", | ||
| "GBP", | ||
| "HUF", | ||
| "PLN", | ||
| "RON", | ||
| "SEK", | ||
| "CHF", | ||
| "ISK", | ||
| "NOK", | ||
| "HRK", | ||
| "RUB", | ||
| "TRY", | ||
| "AUD", | ||
| "BRL", | ||
| "CAD", | ||
| "CNY", | ||
| "HKD", | ||
| "IDR", | ||
| "ILS", | ||
| "INR", | ||
| "KRW", | ||
| "MXN", | ||
| "MYR", | ||
| "NZD", | ||
| "PHP", | ||
| "SGD", | ||
| "THB", | ||
| "ZAR" | ||
| ); |
There was a problem hiding this comment.
These pretty much have to be hardcoded, unless we want to duplicate all the functionality in mod-finance.
bvsharp
commented
Mar 29, 2024
Comment on lines
+153
to
+155
| if (exchangeRate instanceof BigDecimal bd) { | ||
| return bd.doubleValue(); | ||
| } |
There was a problem hiding this comment.
the /exchange-rates API can return a double or a bigdecimal, so we have to check for that here.
bvsharp
force-pushed
the
MODFQMMGR-202-master
branch
from
496790d
to
579b6fe
Compare
|
mweaver-ebsco
approved these changes
Mar 29, 2024
ncovercash
approved these changes
Mar 29, 2024
mweaver-ebsco
pushed a commit
that referenced
this pull request
Apr 17, 2024
* MODFQMMGR-202: Include system exchange rate in Lists app * Update POL definition in 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODFQMMGR-202: Include system exchange rate in Lists app