OKAPI-1181 Implement dependency check option #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uleUtil This commit introduces an option for dependency checking in the TenantManager and ModuleUtil classes. The 'depCheck' option is added to control the execution of dependency resolution and checks within the installation and upgrade processes.
julianladisch
requested review from
steveellis,
julianladisch and
barbaraloehle
okapi-core/src/test/java/org/folio/okapi/managers/TenantManagerTest.java
Outdated
Show resolved
Hide resolved
okapi-core/src/test/java/org/folio/okapi/managers/TenantManagerTest.java
Outdated
Show resolved
Hide resolved
okapi-core/src/test/java/org/folio/okapi/managers/TenantManagerTest.java
Outdated
Show resolved
Hide resolved
okapi-core/src/test/java/org/folio/okapi/managers/TenantManagerTest.java
Outdated
Show resolved
Hide resolved
okapi-core/src/main/java/org/folio/okapi/managers/TenantManager.java
Outdated
Show resolved
Hide resolved
okapi-core/src/main/java/org/folio/okapi/managers/TenantManager.java
Outdated
Show resolved
Hide resolved
okapi-core/src/test/java/org/folio/okapi/managers/TenantManagerTest.java
Show resolved
Hide resolved
okapi-core/src/main/resources/infra-messages/Messages_en.properties
Outdated
Show resolved
Hide resolved
|
julianladisch
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable dependency check option
Approach
Wire up the existing depCheck parameter to be surfaced when TenantInstallOptions class is created. When depCheck is false, skip dependency checking.