Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce accessible routing documentation #497

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Jul 17, 2018

What is this?

This document details the things @wwilsman & I learned while spiking an approach to make the FOLIO UI module we work on accessibile. You can see this work in action in the demos that happened for sprint review 40-41, @cowboyd did a great job! Here's a direct link to that demo on YouTube.

This document is written as a way to describe what we learned so other developers FOLIO can use this as a launch point for making their apps accessibile. This document does not describe the way to make your app accessibile.

As always we are always happy to help with any questions you might have regarding accessibility :)

Lastly here's the PR to eHoldings that was the implementation of this work: folio-org/ui-eholdings#448

Link to the rendered document

TODOs

  • Should this be linked in the README? If so, where?

@Robdel12 Robdel12 changed the title Introduce accessibile routing documentation Introduce accessible routing documentation Jul 17, 2018
@JohnC-80
Copy link
Contributor

I've added a section to the top-level readme for the patterns files. If ya wanna merge master and add a link to this in that section, that'd be great. I also think it should be linked in the Accessibility.md file in the docs folder.

Copy link
Collaborator

@cherewaty cherewaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Robdel12
Copy link
Contributor Author

Okay cool, I rebased and added the links to the README and the accessibility doc :D

Copy link
Contributor

@JohnC-80 JohnC-80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Robdel12!

@Robdel12 Robdel12 merged commit bd6bab7 into master Jul 19, 2018
@Robdel12 Robdel12 deleted the rd/routing-document branch July 19, 2018 14:15
@Robdel12
Copy link
Contributor Author

Woop woop! 🎉 I'm excited this made it's way in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants