Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C375176 Error notifications shown before confirmation modals when saving "MARC bib" record while editing record (Spitfire) (TaaS) #2463

Merged
merged 4 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ describe('data-import', () => {
secondFieldId = resp.id;
});
});
cy.loginAsAdmin();
});

after('delete test data', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import { DevTeams, TestTypes, Permissions } from '../../support/dictionary';
import TopMenu from '../../support/fragments/topMenu';
import Users from '../../support/fragments/users/users';
import InventoryInstance from '../../support/fragments/inventory/inventoryInstance';
import QuickMarcEditor from '../../support/fragments/quickMarcEditor';
import InventoryInstances from '../../support/fragments/inventory/inventoryInstances';
import getRandomPostfix from '../../support/utils/stringTools';
import DataImport from '../../support/fragments/data_import/dataImport';
import JobProfiles from '../../support/fragments/data_import/job_profiles/jobProfiles';
import Logs from '../../support/fragments/data_import/logs/logs';

describe('MARC -> MARC Bibliographic -> Edit MARC bib', () => {
const testData = {
createdRecordIDs: [],
tag0: '0',
tag040: '040',
tag300: '300',
tag300content: 'TEST',
tagLDR: 'LDR',
invalidLDR: '01338cas\\a2200409\\\\\\450',
validLDR: '01338cas\\a2200409\\\\\\4500',
errorMessage:
'Record cannot be saved. The Leader must contain 24 characters, including null spaces.',
};
const marcFile = {
marc: 'marcBibFileForC375176.mrc',
fileName: `C375176 testMarcFile${getRandomPostfix()}.mrc`,
jobProfileToRun: 'Default - Create instance and SRS MARC Bib',
numOfRecords: 1,
};

before('Creating data', () => {
cy.createTempUser([
Permissions.inventoryAll.gui,
Permissions.uiQuickMarcQuickMarcBibliographicEditorAll.gui,
]).then((userProperties) => {
testData.user = userProperties;

cy.loginAsAdmin({ path: TopMenu.dataImportPath, waiter: DataImport.waitLoading }).then(() => {
DataImport.verifyUploadState();
DataImport.uploadFileAndRetry(marcFile.marc, marcFile.fileName);
JobProfiles.waitLoadingList();
JobProfiles.search(marcFile.jobProfileToRun);
JobProfiles.runImportFile();
JobProfiles.waitFileIsImported(marcFile.fileName);
Logs.checkStatusOfJobProfile('Completed');
Logs.openFileDetails(marcFile.fileName);
for (let i = 0; i < marcFile.numOfRecords; i++) {
Logs.getCreatedItemsID(i).then((link) => {
testData.createdRecordIDs.push(link.split('/')[5]);
});
}
});

cy.login(testData.user.username, testData.user.password, {
path: TopMenu.inventoryPath,
waiter: InventoryInstances.waitContentLoading,
});
});
});

after('Deleting test user and an inventory instance', () => {
cy.getAdminToken().then(() => {
Users.deleteViaApi(testData.user.userId);
InventoryInstance.deleteInstanceViaApi(testData.createdRecordIDs[0]);
});
});

it(
'C375176 Error notifications shown before confirmation modals when saving "MARC bib" record while editing record (Spitfire) (TaaS)',
{ tags: [TestTypes.extendedPath, DevTeams.spitfire] },
() => {
InventoryInstances.waitContentLoading();
InventoryInstance.searchByTitle(testData.createdRecordIDs[0]);
InventoryInstances.selectInstance();
InventoryInstance.editMarcBibliographicRecord();
QuickMarcEditor.updateExistingTagName(testData.tag040, testData.tag0);
QuickMarcEditor.updateExistingField(testData.tagLDR, testData.invalidLDR);
QuickMarcEditor.deleteTag(13);
QuickMarcEditor.updateExistingField(testData.tag300, testData.tag300content);
QuickMarcEditor.pressSaveAndKeepEditing(testData.errorMessage);
QuickMarcEditor.updateExistingField(testData.tagLDR, testData.validLDR);
QuickMarcEditor.pressSaveAndClose();
QuickMarcEditor.verifyAndDismissWrongTagLengthCallout();
QuickMarcEditor.closeCallout();
QuickMarcEditor.updateExistingTagName(testData.tag0, testData.tag040);
QuickMarcEditor.pressSaveAndClose();
QuickMarcEditor.verifyConfirmModal();
QuickMarcEditor.clickRestoreDeletedField();
QuickMarcEditor.checkDeleteModalClosed();
QuickMarcEditor.checkButtonsEnabled();
},
);
});
1 change: 1 addition & 0 deletions cypress/fixtures/marcBibFileForC375176.mrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
01240cas a2200397 450000100070000000500170000700800410002401000170006502200140008203500260009603500220012203500110014403500190015504000440017405000150021808200110023322200420024424500430028626000470032926500380037630000150041431000220042932100250045136200230047657000290049965000330052865000450056165500420060670000450064885300180069386300230071190200160073490500210075094800370077195000340080836683220141106221425.0750907c19509999enkqr p 0 a0eng d a 58020553  a0022-0469 a(CStRLIN)NYCX1604275S a(NIC)notisABP6388 a366832 a(OCoLC)1604275 dCtYdMBTIdCtYdMBTIdNICdCStRLINdNIC0 aBR140b.J6 a270.0504aThe Journal of ecclesiastical history04aThe Journal of ecclesiastical history. aLondon,bCambridge University Press [etc.] a32 East 57th St., New York, 10022 av.b25 cm. aQuarterly,b1970- aSemiannual,b1950-690 av. 1- Apr. 1950- aEditor: C. W. Dugmore. 0aChurch historyxPeriodicals. 7aChurch history2fast0(OCoLC)fst00860740 7aPeriodicals2fast0(OCoLC)fst014116411 aDugmore, C. W.q(Clifford William),eed.0381av.i(year)4081a1-49i1950-1998 apfndbLintz a19890510120000.02 a20141106bmdbatcheltsxaddfast lOLINaBR140b.J86h01/01/01 N
Loading