Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2910 *BREAKING* Added a new stripes-inventory-components dependency. Move some utils to that module. #2484

Merged
merged 4 commits into from
May 22, 2024
Merged

UIIN-2910 *BREAKING* Added a new stripes-inventory-components dependency. Move some utils to that module. #2484

merged 4 commits into from
May 22, 2024

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented May 20, 2024 •
edited

Description

Added stripes-inventory-components to peerDeps list
Moved advanced search query builder util to stripes-inventory-components

Issues

UIIN-2910

Related PRs

folio-org/stripes-inventory-components#37

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited

Jest Unit Test Statistics

       1 files  ±0     249 suites  ±0   12m 40s ⏱️ -13s
1 016 tests ±0  1 014 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
1 022 runs  ±0  1 020 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 893a5d3. ± Comparison against base commit 92818ca.

♻️ This comment has been updated with latest results.

This was referenced May 20, 2024
Merged
Merged
zburke
zburke approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine, once you get the first PR merged in stripes-inventory-components.

Since you've called out the breaking change in the README (thank you!), you should actually update the version in package.json as well.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
20.0% Duplication on New Code

See analysis details on SonarCloud

@BogdanDenis BogdanDenis merged commit 399a8c6 into master May 22, 2024
5 checks passed
@BogdanDenis BogdanDenis deleted the UIIN-2910 branch May 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@OleksandrHladchenko1 OleksandrHladchenko1 Awaiting requested review from OleksandrHladchenko1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@BogdanDenis @zburke @mariia-aloshyna @Dmytro-Melnyshyn