UIQM-660 *BREAKING* Added stripes-inventory-components to peerDeps. Added inventory search link next to 010 fields.
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Added inventory search link next to 010 fields.
Comment on lines
+23
to
+25
| bool: 'or', | ||
| query: value, | ||
| match: 'exactPhrase', |
There was a problem hiding this comment.
Let's use constants from stripes-components. It will be easier if someone decides to change exactPhrase to something else.
| const builtQuery = advancedSearchQueryBuilder(advancedSearchRows); | ||
|
|
||
| const searchParams = new URLSearchParams({ | ||
| qindex: 'advancedSearch', |
There was a problem hiding this comment.
Please create a constant for 'advancedSearch' in stripes-inventory-components.
| import { render } from '@folio/jest-config-stripes/testing-library/react'; | ||
|
|
||
| import { runAxeTest } from '@folio/stripes-testing'; | ||
| import { advancedSearchQueryBuilder } from '@folio/stripes-inventory-components'; |
There was a problem hiding this comment.
Please remove eslint warnings.
zburke
approved these changes
May 22, 2024
There was a problem hiding this comment.
@Dmytro-Melnyshyn's suggestions are solid; please follow them.
Please be sure to update the version in package.json as indicated in CHANGELOG.
Dmytro-Melnyshyn
approved these changes
May 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
stripes-inventory-componentsto peerDeps.Added inventory search link next to 010 fields. The link will open Inventory app in a new tab with advanced search by lccn with
010 $a/$zas valuesScreenshots
chrome_IGgyw8MPH1.mp4
Issues
UIQM-660
Related PRs
folio-org/ui-inventory#2484
folio-org/stripes-inventory-components#37