Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-2938: Use facets and the function for building a search query from stripes-inventory-components. #2507

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jun 13, 2024

Purpose

To have common things related to facets and search in stripes-inventory-components to reuse them in ui-plugin-find-instance.

Description

  • exported filter config;
  • exported facets-related components (InstanceFilters, HoldingsRecordFilters, ItemFilters) to stripes-inventory-components to also use them in ui-plugin-find-instance;
  • created renderFilters function to avoid duplications in instanceFilterRenderer, holdingsRecordFilterRenderer, instanceFilterRenderer;
  • exported buildQuery function (for building Search query), renamed it to buildSearchQuery (became compatible with ui-plugin-find-instance),
  • constants browseFiltersConfig, instanceBrowseSortMap, browseConfig have been deleted - they are not used anywhere (legacy code);
  • exported constansts holdingIndexes, holdingFilterConfig, itemIndexes, itemFilterConfig, config for using them also in plugin;
  • removed tags fetching from DataProvider - tags data is not used anywhere.

Once related PR is merged the tests will pass.

Related PRs

folio-org/stripes-inventory-components#47

Refs

UIIN-2938

Screenshots

2024-06-14_13h40_36.mp4

Copy link

github-actions bot commented Jun 13, 2024

Jest Unit Test Statistics

    1 files  ±  0  237 suites   - 7   12m 46s ⏱️ -35s
885 tests  - 51  883 ✔️  - 51  2 💤 ±0  0 ±0 
891 runs   - 51  889 ✔️  - 51  2 💤 ±0  0 ±0 

Results for commit 288571b. ± Comparison against base commit 483cb8c.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn changed the title UIIN-2938: Import facets and the function for building a search query from stripes-inventory-components. UIIN-2938: Use facets and the function for building a search query from stripes-inventory-components. Jun 14, 2024
…ant only, EffectiveLocationFacet - for consortia
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team June 18, 2024 08:14
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit e9fd5ab into master Jun 18, 2024
4 of 5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-2938 branch June 18, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants