UIIN-2938: Use facets and the function for building a search query from stripes-inventory-components
.
#2507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To have common things related to facets and search in
stripes-inventory-components
to reuse them inui-plugin-find-instance
.Description
InstanceFilters
,HoldingsRecordFilters
,ItemFilters
) tostripes-inventory-components
to also use them inui-plugin-find-instance
;renderFilters
function to avoid duplications ininstanceFilterRenderer
,holdingsRecordFilterRenderer
,instanceFilterRenderer
;buildQuery
function (for building Search query), renamed it tobuildSearchQuery
(became compatible withui-plugin-find-instance
),browseFiltersConfig
,instanceBrowseSortMap
,browseConfig
have been deleted - they are not used anywhere (legacy code);holdingIndexes
,holdingFilterConfig
,itemIndexes
,itemFilterConfig
,config
for using them also in plugin;DataProvider
- tags data is not used anywhere.Once related PR is merged the tests will pass.
Related PRs
folio-org/stripes-inventory-components#47
Refs
UIIN-2938
Screenshots
2024-06-14_13h40_36.mp4