Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISINVCOMP-7: Add buildSearchQuery compatible with ui-inventory and ui-plugin-find-instance; add filter components. #47

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jun 13, 2024

Purpose

To have common things related to facets and search in stripes-inventory-components to reuse them in ui-inventory and ui-plugin-find-instance.

Description

  • imported filter config;
  • imported buildQuery function from inventory, renamed it to buildSearchQuery, and modified it to make it compatible with ui-plugin-find-instance;
  • imported facets-related components (InstanceFilters, HoldingsRecordFilters, ItemFilters) to also use them in plugin (added handleClear, changed props).

Issues

UISINVCOMP-7

Screencast

2024-06-14_13h40_36.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

…i-plugin-find-instance; add filter components.
Copy link

github-actions bot commented Jun 13, 2024

Jest Unit Test Statistics

108 tests  +47   108 ✔️ +47   1m 46s ⏱️ +39s
  16 suites +  4       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit dd04136. ± Comparison against base commit d99d7d3.

This pull request removes 2 and adds 49 tests. Note that renamed tests count towards both.
getQueryTemplate when a searchable index is in sub indexes should return a queryTemplate ‑ getQueryTemplate when a searchable index is in sub indexes should return a queryTemplate
getQueryTemplate when a searchable index is not in sub indexes should return a queryTemplate ‑ getQueryTemplate when a searchable index is not in sub indexes should return a queryTemplate
HoldingsRecordFilters Should Render Held by, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render Held by, Clear selectedfilters buttons
HoldingsRecordFilters Should Render effectiveLocation, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render effectiveLocation, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsCreatedDate, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsCreatedDate, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsDiscoverySuppress, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsDiscoverySuppress, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsPermanentLocation, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsPermanentLocation, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsSource, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsSource, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsStatisticalCodeIds, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsStatisticalCodeIds, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsType, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsType, Clear selectedfilters buttons
HoldingsRecordFilters Should Render holdingsUpdatedDate, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render holdingsUpdatedDate, Clear selectedfilters buttons
HoldingsRecordFilters Should Render shared, Clear selectedfilters buttons ‑ HoldingsRecordFilters Should Render shared, Clear selectedfilters buttons
…

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team June 18, 2024 08:14
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit ee2ced3 into main Jun 18, 2024
4 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UISINVCOMP-7 branch June 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants