UIIN-2760: Add Bound items accordion in item record #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const mockUnboundPiece = jest.fn().mockResolvedValue(() => Promise.resolve()); | ||
|
|
||
| const renderBoundPiecesList = (props = {}) => (render( | ||
| <IntlProvider locale="en"> |
There was a problem hiding this comment.
you could use renderWithIntl() instead of wrapping in provider
| }); | ||
| }); | ||
|
|
||
| afterEach(cleanup); |
There was a problem hiding this comment.
cleanup is called automatically, you do not need to call it manually
Comment on lines
14
to
19
| [PIECE_COLUMNS.barcode]: <FormattedMessage id="ui-receiving.piece.barcode" />, | ||
| [PIECE_COLUMNS.displaySummary]: <FormattedMessage id="ui-receiving.piece.displaySummary" />, | ||
| [PIECE_COLUMNS.chronology]: <FormattedMessage id="ui-receiving.piece.chronology" />, | ||
| [PIECE_COLUMNS.copyNumber]: <FormattedMessage id="ui-receiving.piece.copyNumber" />, | ||
| [PIECE_COLUMNS.enumeration]: <FormattedMessage id="ui-receiving.piece.enumeration" />, | ||
| [PIECE_COLUMNS.receiptDate]: <FormattedMessage id="ui-receiving.piece.receiptDate" />, |
There was a problem hiding this comment.
lets add these translations to ui-inventory translations to not rely on a module that is not listed in package.json
| it('should render component', () => { | ||
| renderBoundPiecesList(); | ||
|
|
||
| expect(screen.getByText('ui-receiving.piece.displaySummary')).toBeInTheDocument(); |
There was a problem hiding this comment.
Suggested change
| expect(screen.getByText('ui-receiving.piece.displaySummary')).toBeInTheDocument(); | |
| expect(screen.getByText(/display summary/i)).toBeInTheDocument(); |
|
mariia-aloshyna
approved these changes
Jun 19, 2024
usavkov-epam
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIIN-2760: Add Bound items accordion in item record
Approach
Refs
Screenshots
Screen.Recording.2024-06-17.at.14.30.20.mp4