UIPFI-145: Integrate facets, use buildSearchQuery for building a search query.

[Dmytro-Melnyshyn]

Purpose

Integrate facets, use buildSearchQuery for building a search query, and use common search config.

Related PRs

folio-org/stripes-inventory-components#47

Description

• imported facets-related components (InstanceFilters, HoldingsRecordFilters, ItemFilters);
• created renderFilters function to avoid duplications in instanceFilterRenderer, holdingsRecordFilterRenderer, instanceFilterRenderer;
• imported buildSearchQuery for building the Search query;
• applied common search config;
• removed tags fetching from DataProvider - tags data is not used anywhere;
• deleted unnecessary code/files;
• applied the useCommonData hook in DataProvider;

Once related PR is merged the tests will pass.

Refs

UIPFI-145

Screenshots

2024-06-14_13h40_36.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Statistics

  1 files  ±  0    9 suites   - 15   1m 28s ⏱️ +7s
45 tests  - 89  45 ✔️  - 89  0 💤 ±0  0 ❌ ±0 
45 runs   - 93  45 ✔️  - 93  0 💤 ±0  0 ❌ ±0 

Results for commit 211e7ab. ± Comparison against base commit 23de341.

This pull request removes 102 and adds 13 tests. Note that renamed tests count towards both.

CheckboxFacet Component should render ‑ CheckboxFacet Component should render
CheckboxFacet More options should render when More button is click ‑ CheckboxFacet More options should render when More button is click
CheckboxFacet No matching options should be render when required search is not found ‑ CheckboxFacet No matching options should be render when required search is not found
CheckboxFacet component should re-render  ‑ CheckboxFacet component should re-render 
CheckboxFacet components.readonly should be render when readonly property is true ‑ CheckboxFacet components.readonly should be render when readonly property is true
CheckboxFacetList Component should render correctly ‑ CheckboxFacetList Component should render correctly
CheckboxFacetList checkbox should not render when isPending is true ‑ CheckboxFacetList checkbox should not render when isPending is true
CheckboxFacetList noMatchingOptions should be render when dataOptions is empty ‑ CheckboxFacetList noMatchingOptions should be render when dataOptions is empty
CheckboxFacetList onSearch to be triggered when typing in the search field ‑ CheckboxFacetList onSearch to be triggered when typing in the search field
DataProvider should pass data to children component ‑ DataProvider should pass data to children component
…

DataProvider1 should pass data to children component2 ‑ DataProvider1 should pass data to children component2
FindInstance should render with no axe errors ‑ FindInstance should render with no axe errors
FindInstance when isMultiSelect is applied and a user selects instances and clicks save should call useInstancesQuery with the selected instances ‑ FindInstance when isMultiSelect is applied and a user selects instances and clicks save should call useInstancesQuery with the selected instances
FindInstance when the useInstancesQuery returns an error should display an error message ‑ FindInstance when the useInstancesQuery returns an error should display an error message
FindInstance when the useInstancesQuery returns an error should display the "communication problem" error message ‑ FindInstance when the useInstancesQuery returns an error should display the "communication problem" error message
FindInstance when the useInstancesQuery returns data and isMultiSelect is false should call callbacks ‑ FindInstance when the useInstancesQuery returns data and isMultiSelect is false should call callbacks
FindInstance when the useInstancesQuery returns data and isMultiSelect is true should call callbacks ‑ FindInstance when the useInstancesQuery returns data and isMultiSelect is true should call callbacks
FindInstanceContainer buildSearchQuery when query is empty should return empty query parameters ‑ FindInstanceContainer buildSearchQuery when query is empty should return empty query parameters
FindInstanceContainer buildSearchQuery when query is not empty should return correct query parameters ‑ FindInstanceContainer buildSearchQuery when query is not empty should return correct query parameters
FindInstanceContainer buildSearchQuery when user did touch staff suppress should return cql string with staff suppress filter ‑ FindInstanceContainer buildSearchQuery when user did touch staff suppress should return cql string with staff suppress filter
…

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 211e7ab. ± Comparison against base commit 23de341.

♻️ This comment has been updated with latest results.

[Dmitriy-Litvinenko]

Could you please fix failed tests?

[Dmytro-Melnyshyn]

Could you please fix failed tests?

Related PR is not merged yet.

[sonarcloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud