STCOM-387 Proof of concept: Eject from Settings smart component #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/STCOM-387
The
<Settings>
smart component contains routing glue, which is at odds with the routing-based architecture strategy outlined in https://issues.folio.org/browse/STRIPES-589.Approach
We have all the UI we need from
stripes-components
to be able to construct this functionality with the<Settings>
smart component, in a way thatui-users
is in complete control of its settings routing.This PR does not rearrange
ui-users
'ssrc/settings
file organization to clearly delineate route/container components from purely presentational view components. That should be a future scope of work.I created a
stripesConnect()
function that makes it easier for route/container components to do their own connection to the data layer, instead of a parent component needing to do it for them.Breaking change
The
<Settings>
smart component attempts to programmatically alphabetize the items in each<NavListSection>
- this PR does not maintain that functionality.Blocking issue
The permission sets UI uses
<EntryManager>
, which also defines routes. With this PR, the permission set routes don't work, since they're nested (and don't use the nested route fork presented here). We'll need to figure out an alternate strategy forui-users
to be able to own those route definitions instead: https://issues.folio.org/browse/STSMACOM-161