Fix tag label formatting, add form integration with api, add responsi…

…ve video sizing without js
fomantic · Jun 25, 2014 · 3e99424 · 3e99424
1 parent 3cf4ca7
commit 3e99424
Show file tree

Hide file tree

Showing 6 changed files with 269 additions and 122 deletions.
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -343,11 +343,27 @@ $.fn.form = function(fields, parameters) {
           }
         },
 
+        set: {
+          success: function() {
+            $module
+              .removeClass(className.error)
+              .addClass(className.success)
+            ;
+          },
+          error: function() {
+            $module
+              .removeClass(className.success)
+              .addClass(className.error)
+            ;
+          }
+        },
+
         validate: {
 
           form: function(event) {
             var
-              allValid = true
+              allValid = true,
+              apiRequest
             ;
             // reset errors
             formErrors = [];
@@ -358,18 +374,19 @@ $.fn.form = function(fields, parameters) {
             });
             if(allValid) {
               module.debug('Form has no validation errors, submitting');
-              $module
-                .removeClass(className.error)
-                .addClass(className.success)
-              ;
+              module.set.error();
               return $.proxy(settings.onSuccess, this)(event);
             }
             else {
               module.debug('Form has errors');
-              $module.addClass(className.error);
+              module.set.error();
               if(!settings.inline) {
                 module.add.errors(formErrors);
               }
+              // prevent ajax submit
+              if($module.data('moduleApi') !== undefined) {
+                event.stopImmediatePropagation();
+              }
               return $.proxy(settings.onFailure, this)(formErrors);
             }
           },

diff --git a/src/definitions/elements/label.less b/src/definitions/elements/label.less
@@ -223,7 +223,7 @@ a.ui.label:hover:before {
 .ui.tag.label:before {
     position: absolute;
     top: @tagTriangleTopOffset;
-    left: @tagTriangleLeftOffset;
+    right: @tagTriangleRightOffset;
     content: '';
 
     background-color: @backgroundColor;
@@ -232,7 +232,7 @@ a.ui.label:hover:before {
     width: @tagTriangleSize;
     height: @tagTriangleSize;
 
-    transform: rotate(45deg);
+    transform: translateY(-50%) translateX(50%) rotate(-45deg);
     transition:
       background 0.1s linear
     ;

diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -732,7 +732,8 @@ $.fn.modal.settings = {
   },
   error : {
     dimmer    : 'UI Dimmer, a required component is not included in this page',
-    method    : 'The method you called is not defined.'
+    method    : 'The method you called is not defined.',
+    notFound  : 'The element you specified could not be found'
   },
   className : {
     active    : 'active',