Skip to content

Commit

Permalink
feat(divider): added variable for border style
Browse files Browse the repository at this point in the history
This was hardcoded as 'solid', but deserves to be a variable design decision.
  • Loading branch information
hugopeek committed May 19, 2020
1 parent 0d6f106 commit 4929629
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/definitions/elements/divider.less
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
---------------*/

.ui.divider:not(.vertical):not(.horizontal) {
border-top: @shadowWidth solid @shadowColor;
border-bottom: @highlightWidth solid @highlightColor;
border-top: @shadowWidth @borderStyle @shadowColor;
border-bottom: @highlightWidth @borderStyle @highlightColor;
}

/*--------------
Expand Down Expand Up @@ -117,8 +117,8 @@
content: '';
z-index: 3;

border-left: @shadowWidth solid @shadowColor;
border-right: @highlightWidth solid @highlightColor;
border-left: @shadowWidth @borderStyle @shadowColor;
border-right: @highlightWidth @borderStyle @highlightColor;

width: 0;
height: @verticalDividerHeight;
Expand Down
1 change: 1 addition & 0 deletions src/themes/default/elements/divider.variables
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
--------------------*/

@margin: 1rem 0;
@borderStyle: solid;

@highlightWidth: 1px;
@highlightColor: @whiteBorderColor;
Expand Down

0 comments on commit 4929629

Please sign in to comment.