Skip to content

Commit

Permalink
fix(*): breakpoints ignoring next breakpoint in some cases
Browse files Browse the repository at this point in the history
Especially recognized in table or grid elements a breakpoint wasn't correctly fetched by the browsers, because the floating max value covers a 0.99 of the "before pixel" (was implemented by #567)
While mathematically correct, it was not working on the browser to correctly recognize the next full pixel again. (768 pixel were still recognized as something below)
I found out that it was working again when we'll use 0.98 of the breakpoint pixel (instead of 0.99.
This way the dpi fix of #567 still works but also fixes #681 now.
While i was testing with different dpi settings and windows resizings, i never came across a value of xxxx.99, so xxxx.98 as a breakpoint should fix both issues now.

Closes #681
  • Loading branch information
lubber-de authored and Sean committed Apr 26, 2019
1 parent 8152b38 commit 7ff01e3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/themes/default/globals/site.variables
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,10 @@


/* Responsive */
@largestMobileScreen : (@tabletBreakpoint - 0.01px);
@largestTabletScreen : (@computerBreakpoint - 0.01px);
@largestSmallMonitor : (@largeMonitorBreakpoint - 0.01px);
@largestLargeMonitor : (@widescreenMonitorBreakpoint - 0.01px);
@largestMobileScreen : (@tabletBreakpoint - 0.02px);
@largestTabletScreen : (@computerBreakpoint - 0.02px);
@largestSmallMonitor : (@largeMonitorBreakpoint - 0.02px);
@largestLargeMonitor : (@widescreenMonitorBreakpoint - 0.02px);


/*-------------------
Expand Down

0 comments on commit 7ff01e3

Please sign in to comment.