fix(modal,flyout): dynamic elements did not reference

Whenever a flyout or modal were dynamically created, the internal element has to be reassigned, otherwise it would always be body. This is especially important when mutationobservers or this-references in callbacks are used
fomantic · Oct 5, 2022 · b4c60c1 · b4c60c1
1 parent 7441393
commit b4c60c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/definitions/modules/flyout.js b/src/definitions/modules/flyout.js
@@ -168,7 +168,6 @@ $.flyout = $.fn.flyout = function(parameters) {
             module.setup.heights();
             module.bind.resize();
           }
-          module.refreshInputs();
           module.bind.events();
           module.observeChanges();
           module.instantiate();
@@ -208,6 +207,7 @@ $.flyout = $.fn.flyout = function(parameters) {
               $('<div/>', {class: className.actions}).appendTo($module);
             }
             $module.prependTo($context);
+            element = $module[0];
           },
           id: function() {
             id = (Math.random().toString(16) + '000000000').slice(2, 10);
@@ -621,6 +621,7 @@ $.flyout = $.fn.flyout = function(parameters) {
                 module.add.keyboardShortcuts();
               }
               module.save.focus();
+              module.refreshInputs();
               if(settings.autofocus) {
                 module.set.autofocus();
               }

diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -153,7 +153,6 @@ $.modal = $.fn.modal = function(parameters) {
             $module.addClass('top aligned');
           }
           module.refreshModals();
-          module.refreshInputs();
           module.bind.events();
           module.observeChanges();
           module.instantiate();
@@ -191,6 +190,7 @@ $.modal = $.fn.modal = function(parameters) {
               $('<div/>', {class: className.actions}).appendTo($module);
             }
             $context.append($module);
+            element = $module[0];
           },
           dimmer: function() {
             var
@@ -574,6 +574,7 @@ $.modal = $.fn.modal = function(parameters) {
                       }
                       module.save.focus();
                       module.set.active();
+                      module.refreshInputs()
                       if(settings.autofocus) {
                         module.set.autofocus();
                       }