Skip to content

Commit

Permalink
Fix border colors to match, add veryStrongTransparentBlack. Increase …
Browse files Browse the repository at this point in the history
…contrast on checkboxes
  • Loading branch information
jlukic committed Apr 7, 2015
1 parent eb2189b commit ded08e3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 2 additions & 0 deletions RELEASE-NOTES.md
Expand Up @@ -104,7 +104,9 @@
- **Input** - Fixed improper left padding on `transparent left icon input` **Thanks @zxfwinder**
- **Input** - Fixed `placeholder` color not changing correctly on focus **Thanks @zxfwinder**
- **Label** - Labels inside `header` now vertical align better by accounting for line height offset
- **List** - Bullets and numbers are no longer selectable in `bulleted list` and `ordered list`
- **List** - Fixed `inverted bulleted list` bullet color
- **List** - Fix first element touches border on `ui horizontal celled list`
- **Loader** - Fix position of `inline centered loader` to be centered correctly
- **Message** - Message now uses `@lineHeight` from `site.variables`
- **Message** - Updated all message colors for legibility
Expand Down
2 changes: 1 addition & 1 deletion src/themes/default/collections/table.variables
Expand Up @@ -188,7 +188,7 @@
@invertedBorder: none;
@invertedCellBorderColor: @whiteBorderColor;
@invertedCellColor: @invertedTextColor;
@invertedHeaderBackground: rgba(0, 0, 0, 0.15);
@invertedHeaderBackground: @veryStrongTransparentBlack;
@invertedHeaderColor: @invertedTextColor;

@invertedDefinitionColumnBackground: @subtleTransparentWhite;
Expand Down
2 changes: 1 addition & 1 deletion src/themes/default/elements/input.variables
Expand Up @@ -18,7 +18,7 @@
@textAlign: left;
@background: #FFFFFF;
@borderWidth: 1px;
@border: @borderWidth solid rgba(0, 0, 0, 0.15);
@border: @borderWidth solid @borderColor;
@boxShadow: none;

@borderRadius: @defaultBorderRadius;
Expand Down
10 changes: 5 additions & 5 deletions src/themes/default/modules/checkbox.variables
Expand Up @@ -65,7 +65,7 @@
@checkboxRadioTop: 1px;
@checkboxRadioLeft: 0px;

@checkboxBulletScale: 0.428571428;
@checkboxBulletScale: 0.428571428; /* 6px @ 14pxrem */
@checkboxBulletColor: @textColor;
@checkboxBulletRadius: @circularRadius;

Expand All @@ -84,7 +84,7 @@
@sliderWidth: @sliderLineWidth;
@sliderHeight: (@sliderHandleSize + @sliderHandleOffset);

@sliderLineHeight: 0.25rem;
@sliderLineHeight: 0.2142rem;
@sliderLineVerticalOffset: 0.4rem;
@sliderLineColor: @neutralCheckbox;
@sliderLineRadius: @circularRadius;
Expand All @@ -94,11 +94,11 @@
@sliderLabelDistance: @sliderLineWidth + 1rem;
@sliderOffLabelColor: @unselectedTextColor;

@sliderOnLineColor: @strongTransparentBlack;
@sliderOnLineColor: @lightBlack;
@sliderOnLabelColor: @selectedTextColor;
@sliderLabelLineHeight: 1rem;

@sliderHoverLaneBackground: @strongTransparentBlack;
@sliderHoverLaneBackground: @veryStrongTransparentBlack;
@sliderHoverLabelColor: @hoveredTextColor;


Expand Down Expand Up @@ -126,7 +126,7 @@
@toggleLabelOffset: 0.15em;


@toggleFocusColor: @strongTransparentBlack;
@toggleFocusColor: @veryStrongTransparentBlack;
@toggleHoverColor: @toggleFocusColor;

@toggleOffLabelColor: @checkboxColor;
Expand Down

0 comments on commit ded08e3

Please sign in to comment.