Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] More field states #1097

Closed
exoego opened this issue Oct 16, 2019 · 4 comments
Closed

[Form] More field states #1097

exoego opened this issue Oct 16, 2019 · 4 comments
Assignees
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone

Comments

@exoego
Copy link
Contributor

exoego commented Oct 16, 2019

Feature Request

Description

ui form supports several states: loading, success, error and warning.

Form's child element field supports only error state.
It would be great if field also support warning state, so warning-level check (can be submited but not recommended) can be visually expresed.

I don't think loading and success arenecessary for field, since it is unlikely to have success/loading in single field.

@exoego exoego self-assigned this Oct 16, 2019
@exoego exoego added lang/css Anything involving CSS type/feat Any feature requests or improvements labels Oct 16, 2019
@jamessampford
Copy link
Contributor

There could potentially be a use case for success - such as a visual password strength check, or showing something entered is valid or unique

Seems there already is loading https://fomantic-ui.com/elements/input.html#loading

@y0hami
Copy link
Member

y0hami commented Oct 16, 2019

@jamessampford loading is for Input not fields see https://jsfiddle.net/fjwk79xs/

@y0hami y0hami added this to the 2.8.0 milestone Oct 16, 2019
@exoego
Copy link
Contributor Author

exoego commented Oct 16, 2019

There could potentially be a use case for success - such as a visual password strength check, or showing something entered is valid or unique

That use-case sounds reasonable 👍

I will open a PR to add success and warning state to field.
loading may be added subsequently when use-case provided.

@exoego exoego changed the title [Form] Field warning state [Form] More field states Oct 16, 2019
@y0hami
Copy link
Member

y0hami commented Oct 16, 2019

@exoego Might as well just add all the states so they are all supported (warning, info, success, error)

@exoego exoego added the state/has-pr An issue which has a related PR open label Oct 16, 2019
@y0hami y0hami added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Nov 5, 2019
@y0hami y0hami closed this as completed in 5b7e53c Nov 14, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

3 participants