Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] [commit 4b1d548] broke smooth: true with preventCrossover: true #1231

Closed
mfeherpataky opened this issue Dec 19, 2019 · 2 comments
Closed
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@mfeherpataky
Copy link

At the moment the DOCS of Fomantic show examples of smoothly repositioned slider.
It however it does not move smoothly, and the slider thumb moves in discreet steps to where the click was registered (even in cases of step: 0).

The root cause is the commit 4b1d548
Commit message says

BREAKING CHANGE: preventCrossover is set to true by default, making this a breaking change.

Current state of affairs: smooth works only when preventCrossover is set to false

Ideas for possible solutions:
(a) handle both smooth: true and preventCrossover: true,
(b) immediately - do not set preventCrossover: true and/or add information to Docs that prevent preventCrossover: true renders smooth: true invalid.

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Dec 19, 2019
@lubber-de
Copy link
Member

We'll look into this, both settings being true should work together of course

@lubber-de lubber-de added this to the 2.8.x milestone Dec 19, 2019
@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Dec 19, 2019
@lubber-de lubber-de modified the milestones: 2.8.x, 2.8.3 Dec 19, 2019
@lubber-de
Copy link
Member

fixed by #1232

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Dec 22, 2019
@y0hami y0hami closed this as completed in 0224c87 Dec 23, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants