Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Build randomly omits 34kB of output #1356

Closed
silverwind opened this issue Mar 7, 2020 · 2 comments · Fixed by #1358
Closed

CSS Build randomly omits 34kB of output #1356

silverwind opened this issue Mar 7, 2020 · 2 comments · Fixed by #1358
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Milestone
2.8.5

Comments

@silverwind
Copy link

silverwind commented Mar 7, 2020 •
edited
Loading

Running the gulp build task seems to randomly omit around 34kB of CSS output in semantic.min.css related to the Transition module which in turn leads to Transition: Element is no longer attached to DOM JS errors when using that build.

To reproduce, clone the master branch, npm install, answer all choices with default and run:

while true; do rm -rf dist && npm run build &>/dev/null && stat --printf="%s" dist/semantic.min.css | xargs; done

It will randomly produce less CSS output, around 30% of times in my sample runs:

1354924
1354924
1321417
1354924
1354924
1321417
1321417
1354924
1354924
1354924
1354924
1354924
1354924
1354924
1321417
1321417
1321417
1321417
1354924

I see this on Node.js 12.16.1 and 13.10.1 on Linux. Adding --series to the gulp arguments does not seem to have any affect.
This was referenced Mar 7, 2020
Closed
Merged
@lubber-de lubber-de added state/awaiting-investigation Anything which needs more investigation type/build Anything related to the build process labels Mar 7, 2020
@lubber-de
Copy link
Member

@ColinFrick Do you have an idea or have time to look into this?

@das7pad das7pad mentioned this issue Mar 7, 2020
Merged
@das7pad
Copy link
Contributor

das7pad commented Mar 7, 2020

I found the race condition. PR is #1358

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug and removed state/awaiting-investigation Anything which needs more investigation labels Mar 7, 2020
@lubber-de lubber-de added this to the 2.8.5 milestone Mar 7, 2020
@lubber-de lubber-de added state/has-pr An issue which has a related PR open tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Mar 7, 2020
silverwind added a commit to silverwind/gitea that referenced this issue Apr 29, 2020
@silverwind
Patch fomantic-ui to workaround build issue
f3eb8a6 
Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679
@silverwind silverwind mentioned this issue Apr 29, 2020
Merged
zeripath added a commit to go-gitea/gitea that referenced this issue Apr 30, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (#11244)
310699b 
* Patch fomantic-ui to workaround build issue

Better workaround than #10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: #11243
Fixes: #10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <Sorien@users.noreply.github.com>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <art27@cantab.net>

Co-authored-by: Sorien <Sorien@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@lubber-de lubber-de mentioned this issue May 31, 2020
Closed
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 1, 2020
@y0hami y0hami closed this as completed Jun 1, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (go-gitea#11244)
04619d2 
* Patch fomantic-ui to workaround build issue

Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <Sorien@users.noreply.github.com>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <art27@cantab.net>

Co-authored-by: Sorien <Sorien@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Projects
None yet
Milestone
2.8.5
Development

Successfully merging a pull request may close this issue.

[build] fix the minified css build das7pad/Fomantic-UI
4 participants
@silverwind @y0hami @das7pad @lubber-de