Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icon] normal size of icon has not the same vertical-align and line-height of each other size #1371

Closed
dutrieux opened this issue Mar 18, 2020 · 2 comments
Closed

[icon] normal size of icon has not the same vertical-align and line-height of each other size #1371

dutrieux opened this issue Mar 18, 2020 · 2 comments
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.8.5

Comments

@dutrieux
Copy link
Contributor

dutrieux commented Mar 18, 2020 •
edited
Loading

Bug Report

Normal size of icon has not the same vertical-align and line-height of each other size

Screenshot

icon

Version

2.8.4
@dutrieux dutrieux changed the title [icon] normal size of icon has not the same vertical-position and line-height of each other size [icon] normal size of icon has not the same vertical-align and line-height of each other size Mar 18, 2020
@lubber-de lubber-de mentioned this issue Mar 18, 2020
Merged
@lubber-de
Copy link
Member

Fixed by #1372

@lubber-de lubber-de added lang/css Anything involving CSS state/has-pr An issue which has a related PR open type/bug Any issue which is a bug or PR which fixes a bug labels Mar 18, 2020
@lubber-de lubber-de added this to the 2.8.5 milestone Mar 18, 2020
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Mar 23, 2020
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 1, 2020
@y0hami y0hami closed this as completed Jun 1, 2020
@lubber-de lubber-de mentioned this issue Jun 5, 2020
Merged
@lubber-de
Copy link
Member

We have to (partly) revert this. See #1503 for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.8.5
Development

No branches or pull requests
3 participants
@dutrieux @y0hami @lubber-de