[Icon,Text] Fix vertical alignment #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
This was referenced Jun 5, 2020
ColinFrick
approved these changes
Jun 10, 2020
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects/partly reverts the vertical alignment of unsized icons of #1372 which unfortunately breaks the vertical alignment in most cases when icons are just used beside inline texts which is probably the most used case.
I obviously hadn't really tested the old PR 🙄
While testing this now, i also recognized the
textelement needs the same line-height setting to avoid overlapping which is also fixed now.Testcase
Broken
https://jsfiddle.net/usfh3tpw/2/
Fixed
https://jsfiddle.net/usfh3tpw/3/
Screenshot
Icon Alignment
2.8.4
2.8.5 Broken
2.8.5 Fixed
Text Height
Broken
Fixed
Closes
go-gitea/gitea#11767
#1371