-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[table] footer row vertical alignment support #1581
Comments
@jamessampford I did a quick check and I think there's no need to change for that. You can simple add |
Ah, that one I didn't check, as was trying on the tfoot row - but tfoot row should support it for consistency with thead + tbody Adjusted fiddle for tfoot row https://jsfiddle.net/9bcsujzo/ |
@jamessampford Yes. I'm aware of that. But, by looking the following definition:
I assumed that it purposes to align top for all table elements when I'm not sure if there was a good reason to force middle alignment for the table footer cells as the following specification:
If there is no valid reason to force middle alignment for footer cell, then I'll prepare a PR to change this behavior by allowing the inheritance of vertical alignment from the class name. |
@ko2in my guess is that it was possibly originally for button alignment It may well be that top and bottom vertical alignment is added as a separate statement, for example:
this way keeps compatibility with middle as the default Updated fiddle https://jsfiddle.net/85db9pju/ |
After some quick testing, i also think we can just change |
OK. I'll prepare PR for that. |
Fixed by #1589 |
Currently, only a table header, row, or cell can adjust its vertical alignment - but this is not supported
for a table footeron a table footer rowThere may be cases where
a cella row may need multiple lines, but other cells in the footer do not, causing it to look weirdAt present, the footer will only support middle vertical alignment, whereas all others inherit the style - I suggest allowing vertical alignment to override this default if/when desired
https://fomantic-ui.com/collections/table.html#vertical-alignment
The text was updated successfully, but these errors were encountered: