Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Can't exclude Table component if Tab is included #2118

Closed
hugopeek opened this issue Sep 23, 2021 · 0 comments · Fixed by #2119
Closed

[Build] Can't exclude Table component if Tab is included #2118

hugopeek opened this issue Sep 23, 2021 · 0 comments · Fixed by #2119
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Milestone
2.9.0

Comments

@hugopeek
Copy link
Contributor

Bug Report

I want to exclude the Table component from semantic.css, to reduce file size. It's still listed as an individual in semantic.json.

This leads to a funky glitch, where the CSS styles for Table are not removed from semantic.css if the Tab component is also included and if table.css is still present under dist/components. Probably a globbing issue in one of the Gulp tasks.

Steps to reproduce

  1. Remove 'table' as component in semantic.json (but don't remove table.css in dist/components)
  2. Make sure 'tab' is still listed as component
  3. Run 'gulp build'
  4. Check semantic.css

Expected result

All table classes should be removed from semantic.css if 'table' is not in the list of components.

Actual result

No reduction in file size for semantic.css. All .ui.table classes are still there.

Version

2.8.8
@hugopeek hugopeek added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Sep 23, 2021
@lubber-de lubber-de added Hacktoberfest Issues for Hacktoberfest! state/awaiting-triage Any issues or pull requests which haven't yet been triaged tag/help-wanted Issues which need help to fix or implement type/build Anything related to the build process and removed state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Sep 23, 2021
hugopeek added a commit to hugopeek/Fomantic-UI that referenced this issue Sep 23, 2021
@hugopeek
Fix exclusion of table component when tab is active
aaee30f 
If there is still a table.css present in dist/components, it will be included in semantic.css.

This is caused by a collision in the globbing mechanism: 'tab' is included in the word 'table', so table.css is included in the package task.

Fixes fomantic#2118
@hugopeek hugopeek mentioned this issue Sep 23, 2021
Merged
@lubber-de lubber-de added this to the 2.9.0 milestone Sep 23, 2021
@lubber-de lubber-de added Hacktoberfest Issues for Hacktoberfest! state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged state/has-pr An issue which has a related PR open tag/help-wanted Issues which need help to fix or implement and removed Hacktoberfest Issues for Hacktoberfest! state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged tag/help-wanted Issues which need help to fix or implement labels Sep 23, 2021
lubber-de pushed a commit that referenced this issue Sep 24, 2021
@hugopeek
fix(build): exclusion of table component when tab is active
2f5aacb 
If there is still a table.css present in dist/components, it will be included in semantic.css.

This is caused by a collision in the globbing mechanism: 'tab' is included in the word 'table', so table.css is included in the package task.

Fixes #2118
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Sep 24, 2021
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

[build] fix exclusion of table component when tab is active hugopeek/Fomantic-UI
2 participants
@hugopeek @lubber-de