Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Placeholder] Placeholder.less doesn't include placeholder.overrides #255

Closed
ColinFrick opened this issue Nov 21, 2018 · 0 comments
Closed

[Placeholder] Placeholder.less doesn't include placeholder.overrides #255

ColinFrick opened this issue Nov 21, 2018 · 0 comments
Assignees
@ColinFrick
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.0

Comments

@ColinFrick
Copy link
Member

Bug Report

Steps

1. Put some custom styles in `placeholder.overrides` (either site or own theme)

2. Run `gulp build` from `./semantic` folder

Expected Result

placeholder.css as well as placeholder.min.css within folder ./dist/components should contain the custom styles from placeholder.overrides.

Actual Result

Custom styles from placeholder.overrides are missing.

Version

2.4.2

Cause

placeholder.less is missing command
.loadUIOverrides();
in its last line.

Testcase

No test needed, just insert
.loadUIOverrides();
in its last line and it will work as expected.

Original SUI Issue

Semantic-Org/Semantic-UI#6679
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Nov 21, 2018
@ColinFrick ColinFrick added this to the 2.7.0 milestone Nov 21, 2018
@ColinFrick ColinFrick self-assigned this Nov 21, 2018
@ColinFrick ColinFrick mentioned this issue Nov 21, 2018
Merged
y0hami pushed a commit that referenced this issue Nov 21, 2018
@ColinFrick
fix(placeholder): append .loadUIOverrides() to the bottom
3af89df 
Closes #255
@y0hami y0hami added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 28, 2018
y0hami pushed a commit that referenced this issue Dec 18, 2018
@ColinFrick
fix(placeholder): append .loadUIOverrides() to the bottom
dce8962 
Closes #255
@y0hami y0hami closed this as completed in 5c05e74 Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ColinFrick ColinFrick

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
3 participants
@ColinFrick @y0hami @lubber-de