Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon Color #436

Closed
brunotourinho opened this issue Jan 28, 2019 · 2 comments
Closed

Icon Color #436

brunotourinho opened this issue Jan 28, 2019 · 2 comments
Assignees
@lubber-de
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.2

Comments

@brunotourinho
Copy link

Bug Report

Steps to reproduce

  1. Create a icon tag
  2. Style some color to it ie.: <i class="red trash icon">

Expected result

Beautiful colored icon

Actual result

Icon color inherited from list item

Testcase

http://jsfiddle.net/9aruhkn8/2/

Version

2.7.1
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Jan 28, 2019
@lubber-de lubber-de self-assigned this Jan 28, 2019
@y0hami
Copy link
Member

y0hami commented Jan 28, 2019

Works when the .item is a div and not a a tag. Seems to be due to this overriding the icon color https://github.com/fomantic/Fomantic-UI/blob/master/src/definitions/elements/list.less#L192

@lubber-de
Copy link
Member

lubber-de commented Jan 28, 2019 •
edited

i'll increase the specificity of the icon colors

@lubber-de lubber-de added this to the 2.7.x milestone Jan 28, 2019
@lubber-de lubber-de mentioned this issue Jan 28, 2019
Merged
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jan 29, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 29, 2019
@y0hami y0hami closed this as completed in 588067f Feb 5, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

No branches or pull requests
3 participants
@y0hami @brunotourinho @lubber-de