Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Increase color specificity #438

Merged
merged 1 commit into from
Jan 29, 2019
Merged

[Icon] Increase color specificity #438

merged 1 commit into from
Jan 29, 2019

Conversation

lubber-de
Copy link
Member

Description

This PR increases color specificity, so icons in links of a list item won't be overridden by the default grey

Testcase

http://jsfiddle.net/qy3ptbka/1/
Remove CSS to see the issue

Closes

#436

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 28, 2019
y0hami
y0hami approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.7.x milestone Jan 28, 2019
ColinFrick
ColinFrick approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 588067f into fomantic:develop Jan 29, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 29, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 29, 2019
@lubber-de lubber-de deleted the fix/436/icon_color_specificity branch January 29, 2019 13:59
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
@lubber-de lubber-de mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lubber-de @ColinFrick @y0hami