-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Positioning issue of floating label with pointing menu #668
Comments
Fixed by #669 |
Thanks for the fix, but there's still quite a lot of whitespace between the menu item and the label, so the appearance is still not quite optimal in my opinion. I tweaked the margins a bit further and margin-top: 1em seems to be more attractive |
Even, if I agree it looks a bit unusual, the related fix corrects a logical issue leaving the floating label at the same consistent position as in the other menu variants now. Just because secondary pointing doesn't have a top border, it looks different, but the label is still in the same position as in the other menu variants now. |
Cool, my first PR! I'll investigate! :) |
Bug Report
Positioning of floating label with pointing menu is not optimal
Steps to reproduce
See fiddle
Expected result
The floating label should be better positioned with pointing menus
Actual result
Positioning is too high
Testcase
https://jsfiddle.net/kswyvoab/
Screenshot (when possible)
Normal menu
![Screenshot_20190415_084129](https://user-images.githubusercontent.com/14614620/56112112-5c323380-5f5a-11e9-8538-77a7c9985a48.png)
Pointing menu
![Screenshot_20190415_084111](https://user-images.githubusercontent.com/14614620/56112119-5fc5ba80-5f5a-11e9-9baf-c5dba7c84f78.png)
Version
2.7.2
The text was updated successfully, but these errors were encountered: