Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning issue of floating label with pointing menu #668

Closed
aardbol opened this issue Apr 15, 2019 · 4 comments
Closed

Positioning issue of floating label with pointing menu #668

aardbol opened this issue Apr 15, 2019 · 4 comments
Assignees
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@aardbol
Copy link

aardbol commented Apr 15, 2019

Bug Report

Positioning of floating label with pointing menu is not optimal

Steps to reproduce

See fiddle

Expected result

The floating label should be better positioned with pointing menus

Actual result

Positioning is too high

Testcase

https://jsfiddle.net/kswyvoab/

Screenshot (when possible)

Normal menu
Screenshot_20190415_084129

Pointing menu
Screenshot_20190415_084111

Version

2.7.2

@lubber-de lubber-de added type/feat Any feature requests or improvements type/bug Any issue which is a bug or PR which fixes a bug and removed type/feat Any feature requests or improvements labels Apr 15, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 15, 2019
@lubber-de lubber-de self-assigned this Apr 15, 2019
@lubber-de lubber-de added the lang/css Anything involving CSS label Apr 15, 2019
@lubber-de
Copy link
Member

Fixed by #669
See your adjusted example here https://jsfiddle.net/gv2br0zu/

@aardbol
Copy link
Author

aardbol commented Apr 15, 2019

Thanks for the fix, but there's still quite a lot of whitespace between the menu item and the label, so the appearance is still not quite optimal in my opinion. I tweaked the margins a bit further and margin-top: 1em seems to be more attractive

@lubber-de
Copy link
Member

lubber-de commented Apr 17, 2019

Even, if I agree it looks a bit unusual, the related fix corrects a logical issue leaving the floating label at the same consistent position as in the other menu variants now. Just because secondary pointing doesn't have a top border, it looks different, but the label is still in the same position as in the other menu variants now.
Changing the position only for this menu variant would be an enhancement and as the floating label can also be positioned at the bottom, this also has to be considered and adjustments would be special to secondary pointing menus only.
For now, I suggest you set additional margins in your own overrides. You are welcome to provide another PR with any margin enhancements 😉

@aardbol
Copy link
Author

aardbol commented Apr 17, 2019

Cool, my first PR! I'll investigate! :)

aardbol added a commit to aardbol/Fomantic-UI that referenced this issue Apr 20, 2019
aardbol added a commit to aardbol/Fomantic-UI that referenced this issue May 1, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label May 1, 2019
@y0hami y0hami closed this as completed in ddb7695 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants