Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force position popup calendar in modal #684

Closed
joaquinglezsantos opened this issue Apr 23, 2019 · 4 comments
Closed

Force position popup calendar in modal #684

joaquinglezsantos opened this issue Apr 23, 2019 · 4 comments
Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Milestone
2.7.7

Comments

@joaquinglezsantos
Copy link

Expected result

Popup with position on botton left

Actual result

Popup with position calculations

Testcase

https://codepen.io/Jgonzalez92/pen/zXJKEv
@exoego
Copy link
Contributor

exoego commented May 1, 2019

Could you add more detail why forcing popup position is required?
I think automatic positioning is good for end-users since it can adapt screen sizes.

image

@exoego exoego added needs more info state/awaiting-response Issues or pull requests waiting for a response type/feat Any feature requests or improvements and removed needs more info labels May 1, 2019
@joaquinglezsantos
Copy link
Author

Because when you have "scrolling content" in modal, all content inside with popups aligned on left or right is hidden, but when is popup bottom is shown.

@lubber-de lubber-de mentioned this issue Jul 16, 2019
Merged
@lubber-de
Copy link
Member

Implemented a new setting forcePosition by #880 which should do the job.
See https://jsfiddle.net/0cxn2gy3/

@lubber-de lubber-de removed the state/awaiting-response Issues or pull requests waiting for a response label Jul 16, 2019
@lubber-de lubber-de added this to the 2.7.7 milestone Jul 16, 2019
@lubber-de lubber-de added the lang/javascript Anything involving JavaScript label Jul 16, 2019
@exoego exoego reopened this Jul 17, 2019
@exoego exoego added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 17, 2019
@exoego
Copy link
Contributor

exoego commented Jul 17, 2019 •
edited
Loading

In FUI repo, the addressed issues should be kept open until released.

@y0hami y0hami closed this as completed in e103541 Jul 28, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.7
Development

No branches or pull requests
3 participants
@exoego @joaquinglezsantos @lubber-de